Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(391)

Issue 11351004: Reland 166821 - Lazy initialization for ProcessesEventRouter. (Closed)

Created:
8 years, 1 month ago by Yoyo Zhou
Modified:
8 years, 1 month ago
CC:
chromium-reviews, Aaron Boodman, chromium-apps-reviews_chromium.org, youngki
Visibility:
Public.

Description

Reland 166821 - Lazy initialization for ProcessesEventRouter. Using PKS::Shutdown this time. Make it profile-scoped, not a singleton. Construct EventRouter at ExtensionSystem creation time. Implement EventRouter::Observer interface for lazy event router initialization, and use it for processes API. BUG=156715, 159265 TBR=ben@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=166872

Patch Set 1 #

Patch Set 2 : correcter #

Unified diffs Side-by-side diffs Delta from patch set Stats (+258 lines, -106 lines) Patch
M chrome/browser/extensions/api/processes/processes_api.h View 1 6 chunks +34 lines, -18 lines 0 comments Download
M chrome/browser/extensions/api/processes/processes_api.cc View 1 12 chunks +66 lines, -50 lines 0 comments Download
A chrome/browser/extensions/api/processes/processes_api_factory.h View 1 chunk +36 lines, -0 lines 0 comments Download
A chrome/browser/extensions/api/processes/processes_api_factory.cc View 1 chunk +51 lines, -0 lines 0 comments Download
M chrome/browser/extensions/event_router.h View 4 chunks +22 lines, -3 lines 0 comments Download
M chrome/browser/extensions/event_router.cc View 4 chunks +38 lines, -27 lines 0 comments Download
M chrome/browser/extensions/extension_service.h View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/extensions/extension_service.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extension_system.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_system.cc View 3 chunks +3 lines, -4 lines 0 comments Download
M chrome/browser/profiles/profile_dependency_manager.cc View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/chrome_browser_extensions.gypi View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Yoyo Zhou
The only changes from https://chromiumcodereview.appspot.com/11359081/ are in ProcessesAPI: - Unregister in Shutdown() instead of destructor. ...
8 years, 1 month ago (2012-11-09 00:59:16 UTC) #1
Matt Perry
lgtm
8 years, 1 month ago (2012-11-09 01:03:17 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yoz@chromium.org/11351004/1
8 years, 1 month ago (2012-11-09 01:13:08 UTC) #3
commit-bot: I haz the power
Retried try job too often for step(s) browser_tests
8 years, 1 month ago (2012-11-09 03:54:12 UTC) #4
Yoyo Zhou
+youngki FYI
8 years, 1 month ago (2012-11-09 06:07:41 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yoz@chromium.org/11351004/12003
8 years, 1 month ago (2012-11-09 06:07:54 UTC) #6
commit-bot: I haz the power
Change committed as 166872
8 years, 1 month ago (2012-11-09 08:48:44 UTC) #7
Ben Goodger (Google)
8 years, 1 month ago (2012-11-12 16:32:22 UTC) #8
lgtm for the gyp

Powered by Google App Engine
This is Rietveld 408576698