Issue 11348381: cc: Always commit and redraw after scrolling

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11348381: cc: Always commit and redraw after scrolling (Closed)

Created:
8 years ago by Sami

Modified:
8 years ago

Reviewers:
danakj, jamesr, bulach, enne (OOO)

CC:
chromium-reviews, cc-bugs_chromium.org, trchen, klobag.chromium

Base URL:
http://git.chromium.org/git/chromium.git@trunk

Visibility:
Public.

More Reviews

Description

cc: Always commit and redraw after scrolling During the move from WebKit::IntSize to gfx::Vector2d in the compositor code an IntSize::isEmpty() got accidentally replaced with Vector2d::IsZero() in LayerTreeHostImpl::scrollBy(). This caused cases where we'd change the position of a layer during scrolling but didn't schedule a commit or a redraw. This happened for instance when diagonally scrolling a layer against its edge. This patch fixes the issue by always requesting a commit/redraw if any layer was moved while applying the scroll delta. TEST=LayerTreeHostImplTest.scrollByReturnsCorrectValue Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=171069

Patch Set 1 #

Created: 8 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -3 lines)			Patch
	M	cc/layer_tree_host_impl.cc	View		3 chunks	+4 lines, -3 lines	0 comments	Download
	M	cc/layer_tree_host_impl_unittest.cc	View		1 chunk	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/skyostil@chromium.org/11348381/1

8 years ago (2012-12-04 19:07:32 UTC) #3

Message was sent while issue was closed.

klobag / tchen fyi

Expand Messages | Collapse Messages