Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(426)

Issue 11348359: Add strings for a11y names for iOS toolbar buttons. (Closed)

Created:
8 years ago by lliabraa
Modified:
8 years ago
CC:
chromium-reviews
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Add strings for a11y names for iOS toolbar buttons. Also add the new strings to the iOS grit_whitelist.txt BUG=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=171797

Patch Set 1 #

Patch Set 2 : sync'd #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -0 lines) Patch
M build/ios/grit_whitelist.txt View 1 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/app/generated_resources.grd View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
lliabraa
8 years ago (2012-12-03 19:39:06 UTC) #1
lliabraa
8 years ago (2012-12-04 19:17:06 UTC) #2
stuartmorgan
LGTM
8 years ago (2012-12-07 14:24:01 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/lliabraa@chromium.org/11348359/1
8 years ago (2012-12-07 14:31:18 UTC) #4
commit-bot: I haz the power
Failed to apply patch for build/ios/grit_whitelist.txt: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
8 years ago (2012-12-07 14:31:20 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/lliabraa@chromium.org/11348359/6001
8 years ago (2012-12-07 14:59:13 UTC) #6
commit-bot: I haz the power
8 years ago (2012-12-07 17:19:42 UTC) #7
Message was sent while issue was closed.
Change committed as 171797

Powered by Google App Engine
This is Rietveld 408576698