Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(359)

Issue 11348358: Remove an obsolete NULL test for TabContents in NeedsExtensionWebUI. (Closed)

Created:
8 years ago by Matt Perry
Modified:
8 years ago
CC:
chromium-reviews, Avi (use Gerrit)
Visibility:
Public.

Description

Remove an obsolete NULL test for TabContents in NeedsExtensionWebUI. The code that relied on there being a valid TabContents has changed, so we can now create an ExtensionWebUI for all extension URLs. BUG=106255 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=171037

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -12 lines) Patch
M chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc View 3 chunks +5 lines, -12 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
Matt Perry
8 years ago (2012-12-03 19:21:05 UTC) #1
Matt Perry
+avi, FYI
8 years ago (2012-12-03 19:21:37 UTC) #2
Avi (use Gerrit)
Thank you.
8 years ago (2012-12-03 19:23:46 UTC) #3
Evan Stade
lgtm
8 years ago (2012-12-03 19:48:10 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mpcomplete@chromium.org/11348358/1
8 years ago (2012-12-03 20:09:18 UTC) #5
commit-bot: I haz the power
Retried try job too often on mac_rel for step(s) browser_tests
8 years ago (2012-12-04 01:49:32 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mpcomplete@chromium.org/11348358/1
8 years ago (2012-12-04 01:51:40 UTC) #7
commit-bot: I haz the power
Retried try job too often on mac_rel for step(s) browser_tests
8 years ago (2012-12-04 05:22:52 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mpcomplete@chromium.org/11348358/1
8 years ago (2012-12-04 17:47:36 UTC) #9
commit-bot: I haz the power
8 years ago (2012-12-04 20:26:39 UTC) #10
Message was sent while issue was closed.
Change committed as 171037

Powered by Google App Engine
This is Rietveld 408576698