Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Side by Side Diff: PRESUBMIT.py

Issue 11348344: Remove last usages of FindTabbedBrowserDeprecated. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Dear Greg. Moar context. Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | chrome/browser/extensions/api/tabs/tabs.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 """Top-level presubmit script for Chromium. 5 """Top-level presubmit script for Chromium.
6 6
7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts 7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts
8 for more details about the presubmit API built into gcl. 8 for more details about the presubmit API built into gcl.
9 """ 9 """
10 10
(...skipping 154 matching lines...) Expand 10 before | Expand all | Expand 10 after
165 'browser::FindOrCreateTabbedBrowser', 165 'browser::FindOrCreateTabbedBrowser',
166 ( 166 (
167 'This function is deprecated and we\'re working on removing it. Pass', 167 'This function is deprecated and we\'re working on removing it. Pass',
168 'more context to get a Browser*, like a WebContents, window, or session', 168 'more context to get a Browser*, like a WebContents, window, or session',
169 'id. Talk to robertshield@ for more information.', 169 'id. Talk to robertshield@ for more information.',
170 ), 170 ),
171 True, 171 True,
172 (), 172 (),
173 ), 173 ),
174 ( 174 (
175 'browser::FindTabbedBrowserDeprecated',
176 (
177 'This function is deprecated and we\'re working on removing it. Pass',
178 'more context to get a Browser*, like a WebContents, window, or session',
179 'id. Talk to robertshield@ for more information.',
180 ),
181 True,
182 (),
183 ),
184 (
185 'RunAllPending()', 175 'RunAllPending()',
186 ( 176 (
187 'This function is deprecated and we\'re working on removing it. Rename', 177 'This function is deprecated and we\'re working on removing it. Rename',
188 'to RunUntilIdle', 178 'to RunUntilIdle',
189 ), 179 ),
190 True, 180 True,
191 (), 181 (),
192 ), 182 ),
193 ) 183 )
194 184
(...skipping 639 matching lines...) Expand 10 before | Expand all | Expand 10 after
834 'win_aura', 824 'win_aura',
835 'win_rel', 825 'win_rel',
836 ] 826 ]
837 827
838 # Match things like path/aura/file.cc and path/file_aura.cc. 828 # Match things like path/aura/file.cc and path/file_aura.cc.
839 # Same for chromeos. 829 # Same for chromeos.
840 if any(re.search('[/_](aura|chromeos)', f) for f in files): 830 if any(re.search('[/_](aura|chromeos)', f) for f in files):
841 trybots += ['linux_chromeos_clang:compile', 'linux_chromeos_asan'] 831 trybots += ['linux_chromeos_clang:compile', 'linux_chromeos_asan']
842 832
843 return trybots 833 return trybots
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/extensions/api/tabs/tabs.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698