Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(199)

Unified Diff: chrome/browser/resources/ntp_android/ntp_android.js

Issue 11348336: Fix device type icons for "other devices" tab on Android. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/ntp_android/ntp_android.js
diff --git a/chrome/browser/resources/ntp_android/ntp_android.js b/chrome/browser/resources/ntp_android/ntp_android.js
index beada23f4c3ad979c54910fa98eca2a362d7991e..8d1126beb14b1be9d7eb0e27a9404e56cab41287 100644
--- a/chrome/browser/resources/ntp_android/ntp_android.js
+++ b/chrome/browser/resources/ntp_android/ntp_android.js
@@ -1743,19 +1743,19 @@ cr.define('ntp', function() {
clientName = client.name;
var iconStyle;
- if (windows[0].deviceType == 'win' ||
- windows[0].deviceType == 'macosx' ||
- windows[0].deviceType == 'linux' ||
- windows[0].deviceType == 'chromeos' ||
- windows[0].deviceType == 'other') {
+ var deviceType = client.deviceType;
+ if (deviceType == 'win' ||
+ deviceType == 'macosx' ||
+ deviceType == 'linux' ||
+ deviceType == 'chromeos' ||
+ deviceType == 'other') {
iconStyle = 'laptop';
- } else if (windows[0].deviceType == 'phone') {
+ } else if (deviceType == 'phone') {
iconStyle = 'phone';
- } else if (windows[0].deviceType == 'tablet') {
+ } else if (deviceType == 'tablet') {
iconStyle = 'tablet';
} else {
- console.error(
- 'Unknown sync device type found: ', windows[0].deviceType);
+ console.error('Unknown sync device type found: ', deviceType);
iconStyle = 'laptop';
}
var headerList = [{
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698