Clean up SpdySessionDependencies to remove code duplication.

Clean up SpdySessionDependencies to remove code duplication.
Use SpdySessionDependencies in HttpNetworkTransaction and
HttpProxyClientSocketPool tests, instead of hand-rolled alternatives.BUG=


Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=170687

[Ryan Hamilton, 2012-11-30 23:17:00]

Hi Will,

This is part of my effort to move all SPDY statics to HttpNetworkSession::Params
members.  While working on that, I ended up noticing that using
SpdySessionDependencies more consistently would simplify life.  Can you take a
look?

[willchan no longer on Chromium, 2012-12-01 21:00:22]

lgtm

https://codereview.chromium.org/11348333/diff/2001/net/spdy/spdy_test_util_sp...
File net/spdy/spdy_test_util_spdy2.h (right):

https://codereview.chromium.org/11348333/diff/2001/net/spdy/spdy_test_util_sp...
net/spdy/spdy_test_util_spdy2.h:342: class SpdySessionDependencies {
We should probably make this a struct at some point. If that's easy to do here,
can you make that change?

https://codereview.chromium.org/11348333/diff/2001/net/spdy/spdy_test_util_sp...
net/spdy/spdy_test_util_spdy2.h:357: net::HttpNetworkSession::Params
CreateSessionParams();
If it would not require a lot of manual effort (your time is more valuable than
this nit), can you keep this static too, to be consistent with the others?

[Ryan Hamilton, 2012-12-01 22:26:41]

Thanks for the speedy review!

https://codereview.chromium.org/11348333/diff/2001/net/spdy/spdy_test_util_sp...
File net/spdy/spdy_test_util_spdy2.h (right):

https://codereview.chromium.org/11348333/diff/2001/net/spdy/spdy_test_util_sp...
net/spdy/spdy_test_util_spdy2.h:342: class SpdySessionDependencies {
On 2012/12/01 21:00:22, willchan wrote:
> We should probably make this a struct at some point. If that's easy to do
here,
> can you make that change?

Done.

https://codereview.chromium.org/11348333/diff/2001/net/spdy/spdy_test_util_sp...
net/spdy/spdy_test_util_spdy2.h:357: net::HttpNetworkSession::Params
CreateSessionParams();
On 2012/12/01 21:00:22, willchan wrote:
> If it would not require a lot of manual effort (your time is more valuable
than
> this nit), can you keep this static too, to be consistent with the others?

Done.  (only used in a couple places)

[commit-bot: I haz the power, 2012-12-01 22:30:47]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rch@chromium.org/11348333/1009

[commit-bot: I haz the power, 2012-12-02 07:43:36]

Change committed as 170687