Fix logic for BrowserView::GetSavedWindowPlacement

Fix logic for BrowserView::GetSavedWindowPlacement


BUG=158379
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=170557

[stevenjb, 2012-11-30 00:06:28]

The current logic is incorrect for app popups; it includes the header in the
window size calculation. This was introduced in
https://codereview.chromium.org/7739034/ to fix a bug where apps would grow with
each launch because the header was added to the saved window size, and the
larger size would be saved.

I'm not sure if there is a better way to know whether or not a window has been
resized and saved. I think maybe that it would be better to save the content
size and not the total window size, but that seems like a rather large task.

[Daniel Erat, 2012-11-30 00:18:06]

LGTM, but I'm not very knowledgeable about the implications of this.  Scott?

[Ben Goodger (Google), 2012-11-30 01:11:35]

you know i doubt anyone really understands this stuff, but if the tests pass and
you fix any followon bugs, lgtm :-)

(fwiw at some point we should have a set of unit tests for all the various cases
here).

[commit-bot: I haz the power, 2012-11-30 17:50:48]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/stevenjb@chromium.org/11348311/1

[commit-bot: I haz the power, 2012-11-30 21:47:33]

Change committed as 170557