Implement script bubble for GTK.

Implement script bubble for GTK.

Note: The link in the bubble takes you to the chrome://extensions page but does not highlight the extension you clicked on. 

BUG=153137
TBR=ben
TEST=Install an extension with a content script, such as Google Dictionary or Turn of the lights. You should see a puzzle piece in the Omnibox indicating how many content scripts are running on the page. Click the puzzle piece to see a list of extensions running the content scripts.


Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=170425

[Aaron Boodman, 2012-11-29 21:50:03]

erg: Please review chrome/browser/ui/gtk/...
sail: Please review chrome/app/theme/...

[sail, 2012-11-29 21:56:41]

theme/* LGTM
(Please run pngcrush on new icons. Instructions are in theme/README)

[Finnur, 2012-11-29 22:00:16]

Drive-by review...

https://codereview.chromium.org/11348304/diff/1/chrome/app/theme/theme_resour...
File chrome/app/theme/theme_resources.grd (right):

https://codereview.chromium.org/11348304/diff/1/chrome/app/theme/theme_resour...
chrome/app/theme/theme_resources.grd:229: <structure type="chrome_scaled_image"
name="IDR_EXTENSIONS_FAVICON" file="common/script_bubble.png" />
Isn't IDR_EXTENSIONS_FAVICON used elsewhere (besides the script bubble)?

https://codereview.chromium.org/11348304/diff/1/chrome/browser/ui/gtk/script_...
File chrome/browser/ui/gtk/script_bubble_gtk.cc (right):

https://codereview.chromium.org/11348304/diff/1/chrome/browser/ui/gtk/script_...
chrome/browser/ui/gtk/script_bubble_gtk.cc:52: void
ScriptBubbleGtk::OnItemLinkClickedThunk(GtkWidget* sender, void* user_data) {
nit: 80 cols

[Aaron Boodman, 2012-11-29 22:01:54]

https://codereview.chromium.org/11348304/diff/1/chrome/app/theme/theme_resour...
File chrome/app/theme/theme_resources.grd (right):

https://codereview.chromium.org/11348304/diff/1/chrome/app/theme/theme_resour...
chrome/app/theme/theme_resources.grd:229: <structure type="chrome_scaled_image"
name="IDR_EXTENSIONS_FAVICON" file="common/script_bubble.png" />
On 2012/11/29 22:00:16, Finnur wrote:
> Isn't IDR_EXTENSIONS_FAVICON used elsewhere (besides the script bubble)?

Whoops, yeah. Good catch.

[Aaron Boodman, 2012-11-29 22:29:11]

https://codereview.chromium.org/11348304/diff/1/chrome/app/theme/theme_resour...
File chrome/app/theme/theme_resources.grd (right):

https://codereview.chromium.org/11348304/diff/1/chrome/app/theme/theme_resour...
chrome/app/theme/theme_resources.grd:229: <structure type="chrome_scaled_image"
name="IDR_EXTENSIONS_FAVICON" file="common/script_bubble.png" />
On 2012/11/29 22:01:54, Aaron Boodman wrote:
> On 2012/11/29 22:00:16, Finnur wrote:
> > Isn't IDR_EXTENSIONS_FAVICON used elsewhere (besides the script bubble)?
> 
> Whoops, yeah. Good catch.

Done.

https://codereview.chromium.org/11348304/diff/1/chrome/browser/ui/gtk/script_...
File chrome/browser/ui/gtk/script_bubble_gtk.cc (right):

https://codereview.chromium.org/11348304/diff/1/chrome/browser/ui/gtk/script_...
chrome/browser/ui/gtk/script_bubble_gtk.cc:52: void
ScriptBubbleGtk::OnItemLinkClickedThunk(GtkWidget* sender, void* user_data) {
On 2012/11/29 22:00:16, Finnur wrote:
> nit: 80 cols

Done.

[Elliot Glaysher, 2012-11-29 23:59:09]

gtk lgtm

[commit-bot: I haz the power, 2012-11-30 00:11:05]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/aa@chromium.org/11348304/8002

[commit-bot: I haz the power, 2012-11-30 00:11:10]

Presubmit check for 11348304-8002 failed and returned exit status 1.


Running presubmit commit checks ...
Traceback (most recent call last):
  File "/b/commit-queue/verification/presubmit_shim.py", line 43, in <module>
    sys.exit(presubmit_support.Main(argv))
  File "/b/depot_tools/presubmit_support.py", line 1259, in Main
    rietveld_obj)
  File "/b/depot_tools/presubmit_support.py", line 1107, in DoPresubmitChecks
    results += executer.ExecPresubmitScript(presubmit_script, filename)
  File "/b/depot_tools/presubmit_support.py", line 1024, in ExecPresubmitScript
    result = eval(function_name + '(*__args)', context)
  File "<string>", line 1, in <module>
  File "<string>", line 19, in CheckChangeOnCommit
  File "<string>", line 43, in _CommonChecks
  File
"/b/commit-queue/workdir/chromium/chrome/app/theme/../../../ui/resources/resource_check/resource_scale_factors.py",
line 85, in RunChecks
    base_dimensions = ImageSize(base_image)
  File
"/b/commit-queue/workdir/chromium/chrome/app/theme/../../../ui/resources/resource_check/resource_scale_factors.py",
line 47, in ImageSize
    assert data[:8] == '\x89PNG\r\n\x1A\n' and data[12:16] == 'IHDR'
AssertionError

[commit-bot: I haz the power, 2012-11-30 01:22:10]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/aa@chromium.org/11348304/5002

[commit-bot: I haz the power, 2012-11-30 01:22:18]

Presubmit check for 11348304-5002 failed and returned exit status 1.


Running presubmit commit checks ...
Traceback (most recent call last):
  File "/b/commit-queue/verification/presubmit_shim.py", line 43, in <module>
    sys.exit(presubmit_support.Main(argv))
  File "/b/depot_tools/presubmit_support.py", line 1259, in Main
    rietveld_obj)
  File "/b/depot_tools/presubmit_support.py", line 1107, in DoPresubmitChecks
    results += executer.ExecPresubmitScript(presubmit_script, filename)
  File "/b/depot_tools/presubmit_support.py", line 1024, in ExecPresubmitScript
    result = eval(function_name + '(*__args)', context)
  File "<string>", line 1, in <module>
  File "<string>", line 19, in CheckChangeOnCommit
  File "<string>", line 43, in _CommonChecks
  File
"/b/commit-queue/workdir/chromium/chrome/app/theme/../../../ui/resources/resource_check/resource_scale_factors.py",
line 85, in RunChecks
    base_dimensions = ImageSize(base_image)
  File
"/b/commit-queue/workdir/chromium/chrome/app/theme/../../../ui/resources/resource_check/resource_scale_factors.py",
line 47, in ImageSize
    assert data[:8] == '\x89PNG\r\n\x1A\n' and data[12:16] == 'IHDR'
AssertionError

[commit-bot: I haz the power, 2012-11-30 05:43:30]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/aa@chromium.org/11348304/7004

[commit-bot: I haz the power, 2012-11-30 05:43:33]

Presubmit check for 11348304-7004 failed and returned exit status 1.


Running presubmit commit checks ...

** Presubmit ERRORS **
Missing LGTM from an OWNER for files in these directories:
    chrome

Presubmit checks took 1.0s to calculate.

[commit-bot: I haz the power, 2012-11-30 06:44:02]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/aa@chromium.org/11348304/7004

[commit-bot: I haz the power, 2012-11-30 08:40:07]

Change committed as 170425