Removed dead code from chrome/browser/extensions/api/web_request

Removed dead code from chrome/browser/extensions/api/web_request


BUG=161992
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=170672

[vabr (Chromium), 2012-11-30 06:44:26]

On 2012/11/29 21:55:39, sergiyb wrote:

LGTM, thanks Sergiy!
But please at least TBR one of the OWNERS (battre@ or mpcomplete@).

Vaclav

[Sergiy Byelozyorov (Google), 2012-11-30 09:33:31]

Thanks. Added both battre and mpcomplete.

P.S. In Critique LGTM from the OWNER and readability LGTM are required by the
system. Is this the same in Chromium Code Reviews? Do I need LGTM from all
reviewers that I've added or is it sufficient to have LGTM from one of them?

[vabr (Chromium), 2012-11-30 09:39:20]

On 2012/11/30 09:33:31, sergiyb wrote:
> Thanks. Added both battre and mpcomplete.
> 
> P.S. In Critique LGTM from the OWNER and readability LGTM are required by the
> system. Is this the same in Chromium Code Reviews? Do I need LGTM from all
> reviewers that I've added or is it sufficient to have LGTM from one of them?

As far as I know, in Chromium you need to have a review from an OWNER for each
changed file, and a review from at least one committer. If these reviewers
happen to be a single person, that's no problem.

So, here you would need a review from battre@ OR mpcomplete@ (not necessary
both).

My review is technically not necessary (here both OWNERS are committers), but
it's good you looped me in. I wrote that code, and I certify that the deletions
are safe. The OWNERS just need to "rubber-stamp".

Vaclav

[battre, 2012-12-01 03:15:10]

LGTM, thanks.

[commit-bot: I haz the power, 2012-12-01 14:31:24]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sergiyb@google.com/11348299/1

[commit-bot: I haz the power, 2012-12-01 19:44:40]

Change committed as 170672