Issue 11348298: Take instrumentation overhead into account when plotting.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11348298: Take instrumentation overhead into account when plotting. (Closed)

Created:
8 years ago by Yang

Modified:
8 years ago

Reviewers:
Jakob Kummerow

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Take instrumentation overhead into account when plotting. R=jkummerow@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=13146

Patch Set 1 #

Patch Set 2 : #

Total comments: 3

Patch Set 3 : #

Created: 8 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+172 lines, -28 lines)			Patch
M	src/counters.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/flag-definitions.h	View	1 2	1 chunk	+4 lines, -1 line	0 comments	Download
M	src/log.h	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/log.cc	View	1 2	4 chunks	+4 lines, -5 lines	0 comments	Download
M	src/log-utils.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	tools/plot-timer-events	View		1 chunk	+34 lines, -3 lines	0 comments	Download
M	tools/plot-timer-events.js	View	1 2	13 chunks	+124 lines, -13 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Jakob Kummerow

8 years ago (2012-12-05 15:53:15 UTC) #2

Nifty. LGTM with minor comments.

https://codereview.chromium.org/11348298/diff/2002/tools/plot-timer-events.js
File tools/plot-timer-events.js (right):

https://codereview.chromium.org/11348298/diff/2002/tools/plot-timer-events.js...
tools/plot-timer-events.js:237: var next_start_start = next_start ?
next_start.start : Infinity;
redeclaration

https://codereview.chromium.org/11348298/diff/2002/tools/plot-timer-events.js...
tools/plot-timer-events.js:238: var next_end_end = next_end ? next_end.end :
Infinity;
redeclaration

https://codereview.chromium.org/11348298/diff/2002/tools/plot-timer-events.js...
tools/plot-timer-events.js:264: // and shortest range.
I don't see us looking for the largest and shortest range.

Expand Messages | Collapse Messages