Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(549)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 11348284: [telemetry] Adding --output-format option to enable more user-friendly output. (Closed)

Created:
8 years ago by hartmanng
Modified:
8 years ago
Reviewers:
dtu, nduca
CC:
chromium-reviews, chrome-speed-team+watch_google.com, pam+watch_chromium.org, telemetry+watch_chromium.org, Ian Vollick
Visibility:
Public.

Description

[telemetry] Adding --output-format option to enable more user-friendly output. BUG=162923 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=170678

Patch Set 1 : #

Total comments: 8

Patch Set 2 : #

Total comments: 2

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -13 lines) Patch
M tools/telemetry/telemetry/multi_page_benchmark.py View 1 2 chunks +45 lines, -12 lines 0 comments Download
M tools/telemetry/telemetry/multi_page_benchmark_runner.py View 1 2 2 chunks +15 lines, -1 line 0 comments Download

Messages

Total messages: 10 (0 generated)
hartmanng
Please take a look.
8 years ago (2012-11-28 22:34:32 UTC) #1
dtu
https://chromiumcodereview.appspot.com/11348284/diff/5/tools/telemetry/telemetry/browser_options.py File tools/telemetry/telemetry/browser_options.py (right): https://chromiumcodereview.appspot.com/11348284/diff/5/tools/telemetry/telemetry/browser_options.py#newcode75 tools/telemetry/telemetry/browser_options.py:75: '"csv".') You can do '"%default".') to specify the default ...
8 years ago (2012-11-29 01:30:00 UTC) #2
hartmanng
https://codereview.chromium.org/11348284/diff/5/tools/telemetry/telemetry/browser_options.py File tools/telemetry/telemetry/browser_options.py (right): https://codereview.chromium.org/11348284/diff/5/tools/telemetry/telemetry/browser_options.py#newcode75 tools/telemetry/telemetry/browser_options.py:75: '"csv".') On 2012/11/29 01:30:00, Dave Tu wrote: > You ...
8 years ago (2012-11-29 14:37:44 UTC) #3
nduca
https://codereview.chromium.org/11348284/diff/7001/tools/telemetry/telemetry/browser_options.py File tools/telemetry/telemetry/browser_options.py (right): https://codereview.chromium.org/11348284/diff/7001/tools/telemetry/telemetry/browser_options.py#newcode71 tools/telemetry/telemetry/browser_options.py:71: group.add_option('--output-format', can this be specific to multipage_benchmark_runner please? This ...
8 years ago (2012-11-30 00:22:44 UTC) #4
hartmanng
https://codereview.chromium.org/11348284/diff/7001/tools/telemetry/telemetry/browser_options.py File tools/telemetry/telemetry/browser_options.py (right): https://codereview.chromium.org/11348284/diff/7001/tools/telemetry/telemetry/browser_options.py#newcode71 tools/telemetry/telemetry/browser_options.py:71: group.add_option('--output-format', On 2012/11/30 00:22:45, nduca wrote: > can this ...
8 years ago (2012-11-30 15:51:03 UTC) #5
dtu
cool coolcoolcool lgtm
8 years ago (2012-12-01 01:28:42 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hartmanng@chromium.org/11348284/9001
8 years ago (2012-12-01 18:17:48 UTC) #7
commit-bot: I haz the power
Retried try job too often on linux_rel for step(s) content_unittests
8 years ago (2012-12-01 20:13:56 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hartmanng@chromium.org/11348284/9001
8 years ago (2012-12-01 22:17:16 UTC) #9
commit-bot: I haz the power
8 years ago (2012-12-01 23:09:55 UTC) #10
Message was sent while issue was closed. 
Change committed as 170678

Powered by Google App Engine
This is Rietveld 408576698