Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(189)

Issue 11348275: Remove the flag for the Speech API and turn it on by default. (Closed)

Created:
8 years ago by tommi (sloooow) - chröme
Modified:
8 years ago
Reviewers:
hans, brettw
CC:
chromium-reviews, joi+watch-content_chromium.org, jam, pam+watch_chromium.org, darin-cc_chromium.org
Visibility:
Public.

Description

Remove the flag for the Speech API and turn it on by default. BUG=116954 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=170675

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -26 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/browser/about_flags.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M chrome/tools/chromeactions.txt View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/speech/speech_recognition_dispatcher_host.cc View 1 chunk +1 line, -5 lines 0 comments Download
M content/public/common/content_switches.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/public/common/content_switches.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M content/renderer/render_thread_impl.cc View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
tommi (sloooow) - chröme
Hey Hans - This is a preliminary review request just to make sure I didn't ...
8 years ago (2012-11-28 15:19:47 UTC) #1
hans
On 2012/11/28 15:19:47, tommi wrote: > Hey Hans - This is a preliminary review request ...
8 years ago (2012-11-28 15:51:26 UTC) #2
tommi (sloooow) - chröme
Hey reviewers, This change is to enable the Speech API in chrome. It depends on ...
8 years ago (2012-11-29 10:35:24 UTC) #3
hans
On 2012/11/29 10:35:24, tommi wrote: > Hey reviewers, > > This change is to enable ...
8 years ago (2012-11-29 11:19:37 UTC) #4
brettw
lgtm
8 years ago (2012-11-30 21:00:23 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tommi@chromium.org/11348275/1
8 years ago (2012-12-01 18:12:25 UTC) #6
commit-bot: I haz the power
8 years ago (2012-12-01 20:26:31 UTC) #7
Message was sent while issue was closed.
Change committed as 170675

Powered by Google App Engine
This is Rietveld 408576698