Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(268)

Unified Diff: chrome/browser/autofill/autofill_manager.cc

Issue 11348273: [autofill] Fill in values on a successful run of interactive autocomplete. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: var rename Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/autofill/form_structure.h » ('j') | chrome/common/autofill_messages.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/autofill/autofill_manager.cc
diff --git a/chrome/browser/autofill/autofill_manager.cc b/chrome/browser/autofill/autofill_manager.cc
index 4d08afe9d8666d3640c2e25f4a407cc06ee6f46b..8da907b2ea9f6f59d8d1509ebc4e334e404ea23b 100644
--- a/chrome/browser/autofill/autofill_manager.cc
+++ b/chrome/browser/autofill/autofill_manager.cc
@@ -784,13 +784,12 @@ void AutofillManager::ReturnAutocompleteData(const FormStructure* result) {
return;
if (!result) {
- host->Send(new AutofillMsg_RequestAutocompleteFinished(
- host->GetRoutingID(), WebKit::WebFormElement::AutocompleteResultError));
- } else {
- // TODO(estade): implement non-failure case.
- host->Send(new AutofillMsg_RequestAutocompleteFinished(
- host->GetRoutingID(), WebKit::WebFormElement::AutocompleteResultError));
+ host->Send(new AutofillMsg_RequestAutocompleteError(host->GetRoutingID()));
+ return;
}
+
+ host->Send(new AutofillMsg_RequestAutocompleteSuccess(host->GetRoutingID(),
+ result->ToFormData()));
}
void AutofillManager::OnLoadedServerPredictions(
« no previous file with comments | « no previous file | chrome/browser/autofill/form_structure.h » ('j') | chrome/common/autofill_messages.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698