Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Unified Diff: chrome/common/autofill_messages.h

Issue 11348273: [autofill] Fill in values on a successful run of interactive autocomplete. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: . Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/autofill/form_structure_unittest.cc ('k') | chrome/common/form_data.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/autofill_messages.h
diff --git a/chrome/common/autofill_messages.h b/chrome/common/autofill_messages.h
index b60c868fbf00cb59a43da3bd64c7c386d6635ef2..f17cfd01be16ba2223fa027f502c0af2af7def24 100644
--- a/chrome/common/autofill_messages.h
+++ b/chrome/common/autofill_messages.h
@@ -134,9 +134,16 @@ IPC_MESSAGE_ROUTED1(AutofillMsg_AcceptPasswordAutofillSuggestion,
IPC_MESSAGE_ROUTED1(AutofillMsg_FormNotBlacklisted,
content::PasswordForm /* form checked */)
-// Sent when interactive autocomplete finishes.
-IPC_MESSAGE_ROUTED1(AutofillMsg_RequestAutocompleteFinished,
- WebKit::WebFormElement::AutocompleteResult /* result */)
+// Sent when interactive autocomplete succeeds. Tells the renderer to Autofill
+// the form that requested autocomplete with the |form_data| values input by the
+// user.
+IPC_MESSAGE_ROUTED1(AutofillMsg_RequestAutocompleteSuccess,
James Hawkins 2012/11/30 22:17:25 Optional nit: Consider renaming the message to Aut
Dan Beam 2012/11/30 22:21:04 Done. (changed comment)
+ FormData /* form_data */)
+
+// Sent when interactive autocomplete fails. Currently, this happens when a form
+// is requested to be autocompleted with no input or select tags with
+// autocomplete attributes.
+IPC_MESSAGE_ROUTED0(AutofillMsg_RequestAutocompleteError);
// Autofill messages sent from the renderer to the browser.
« no previous file with comments | « chrome/browser/autofill/form_structure_unittest.cc ('k') | chrome/common/form_data.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698