[autofill] Fill in values on a successful run of interactive autocomplete.

chrome/browser/autofill/form_structure.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/autofill/form_structure.h"
 
 #include <utility>
 
 #include "base/basictypes.h"
 #include "base/command_line.h"
@@ skipping 504 matching lines @@
                             UTF16ToUTF8(form_name_) +
                             form_signature_field_names_;
 
   return Hash64Bit(form_string);
 }
 
 bool FormStructure::IsAutofillable(bool require_method_post) const {
   // TODO(ramankk): Remove this check once we have better way of identifying the
   // cases to trigger experimental form filling.
   if (CommandLine::ForCurrentProcess()->HasSwitch(
-      switches::kEnableExperimentalFormFilling))
+          switches::kEnableExperimentalFormFilling))
     return true;
 
   if (autofill_count() < kRequiredFillableFields)
     return false;
 
   return ShouldBeParsed(require_method_post);
 }
 
 void FormStructure::UpdateAutofillCount() {
   autofill_count_ = 0;
   for (std::vector<AutofillField*>::const_iterator iter = begin();
        iter != end(); ++iter) {
     AutofillField* field = *iter;
     if (field && field->IsFieldFillable())
       ++autofill_count_;
   }
 }
 
 bool FormStructure::ShouldBeParsed(bool require_method_post) const {
   // TODO(ramankk): Remove this check once we have better way of identifying the
   // cases to trigger experimental form filling.
   if (CommandLine::ForCurrentProcess()->HasSwitch(
-      switches::kEnableExperimentalFormFilling))
+          switches::kEnableExperimentalFormFilling))
     return true;
 
   if (field_count() < kRequiredFillableFields)
     return false;
 
   // Rule out http(s)://*/search?...
   //  e.g. http://www.google.com/search?q=...
   //       http://search.yahoo.com/search?p=...
   if (target_url_.path() == "/search")
     return false;
@@ skipping 248 matching lines @@
 }
 
 size_t FormStructure::field_count() const {
   return fields_.size();
 }
 
 std::string FormStructure::server_experiment_id() const {
   return server_experiment_id_;
 }
 
+FormData* FormStructure::ToFormData() const {
+  // TODO(dbeam): Store user_submitted in ctor if it's important.

[Ilya Sherman, 2012/11/28 06:16:39]

It's not important.  Just include a comment that it will always be false.

[Dan Beam, 2012/11/28 19:59:10]

Done.

+  FormData* data = new FormData();

[Ilya Sherman, 2012/11/28 06:16:39]

If you keep the heap allocation, please use a scoped_ptr here.

[Dan Beam, 2012/11/28 19:59:10]

Done.  How would I do this alternatively?  I'm a C++ noob.

+  data->name = form_name_;
+  data->origin = source_url_;
+  data->action = target_url_;
+  data->method = method_;
+
+  for (size_t i = 0; i < fields_.size(); ++i) {
+    const FormFieldData* copy =
+        new AutofillField(*fields_[i], fields_[i]->unique_name());

[Ilya Sherman, 2012/11/28 06:16:39]

This sure looks like it will leak.  Why isn't this just stack allocated?

[Dan Beam, 2012/11/28 19:59:10]

Done.

+    data->fields.push_back(*copy);

[Ilya Sherman, 2012/11/28 06:16:39]

Methinks the body of this for loop should be:

data->fields.push_back(FormFieldData(*fields_[i]));

[Dan Beam, 2012/11/28 19:59:10]

Done.

+  }
+
+  return data;
+}
+
 bool FormStructure::operator==(const FormData& form) const {
   // TODO(jhawkins): Is this enough to differentiate a form?
   if (form_name_ == form.name &&
       source_url_ == form.origin &&
       target_url_ == form.action) {
     return true;
   }
 
   // TODO(jhawkins): Compare field names, IDs and labels once we have labels
   // set up.
@@ skipping 226 matching lines @@
   for (std::vector<AutofillField*>::iterator field = fields_.begin();
        field != fields_.end(); ++field) {
     AutofillType::FieldTypeGroup field_type_group =
         AutofillType((*field)->type()).group();
     if (field_type_group == AutofillType::CREDIT_CARD)
       (*field)->set_section((*field)->section() + "-cc");
     else
       (*field)->set_section((*field)->section() + "-default");
   }
 }