Issue 11348231: Move gl_bindings_skia_cmd_buffer into webkit_gpu and make the latter a component

Issue 11348231: Move gl_bindings_skia_cmd_buffer into webkit_gpu and make the latter a component (Closed)

Created:
8 years ago by piman

Modified:
8 years ago

Reviewers:
jamesr, Ben Goodger (Google)

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, apatrick_chromium, bsalomon_chromium

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Move gl_bindings_skia_cmd_buffer into webkit_gpu and make the latter a component webkit_gpu (implicitly) depends on webkit_glue (and its deep dependencies) just because of this. Moving gl_bindings_skia_cmd_buffer here allows ui/compositor to just depend on webkit_gpu and not glue any more. It also makes somewhat more sense. webkit_gpu should be a component because it's used by both ui/compositor and content/. I think we've been lucky so far without it because each component uses a different subset of webkit_gpu. BUG=159278 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=170303

Patch Set 1 #

Patch Set 2 : fix issues #

Patch Set 3 : fix linux_clang #

Patch Set 4 : add webkit dependency #

Patch Set 5 : finally? #

Patch Set 6 : rebase #

Patch Set 7 : rebase #

Patch Set 8 : missing dep #

Created: 8 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+78 lines, -170 lines)			Patch
M	chrome/chrome_browser.gypi	View	1 2 3 4 5	1 chunk	+1 line, -0 lines	0 comments	Download
M	content/common/gpu/client/webgraphicscontext3d_command_buffer_impl.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	content/content_common.gypi	View	1 2 3 4 5 6 7	1 chunk	+1 line, -0 lines	0 comments	Download
M	content/content_shell.gypi	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	content/content_tests.gypi	View	1 2 3 4 5	1 chunk	+1 line, -0 lines	0 comments	Download
D	webkit/glue/gl_bindings_skia_cmd_buffer.h	View		1 chunk	+0 lines, -21 lines	0 comments	Download
D	webkit/glue/gl_bindings_skia_cmd_buffer.cc	View		1 chunk	+0 lines, -122 lines	0 comments	Download
M	webkit/glue/webkit_glue.gypi	View	1 2 3 4 5	1 chunk	+0 lines, -2 lines	0 comments	Download
A +	webkit/gpu/gl_bindings_skia_cmd_buffer.h	View		1 chunk	+8 lines, -7 lines	0 comments	Download
A +	webkit/gpu/gl_bindings_skia_cmd_buffer.cc	View		3 chunks	+5 lines, -4 lines	0 comments	Download
M	webkit/gpu/webgraphicscontext3d_in_process_command_buffer_impl.h	View		2 chunks	+4 lines, -2 lines	0 comments	Download
M	webkit/gpu/webgraphicscontext3d_in_process_command_buffer_impl.cc	View		2 chunks	+2 lines, -5 lines	0 comments	Download
M	webkit/gpu/webgraphicscontext3d_in_process_impl.h	View		2 chunks	+4 lines, -1 line	0 comments	Download
M	webkit/gpu/webkit_gpu.gypi	View	1 2 3 4 5 6	3 chunks	+18 lines, -4 lines	0 comments	Download
A	webkit/gpu/webkit_gpu_export.h	View		1 chunk	+29 lines, -0 lines	0 comments	Download
M	webkit/support/webkit_support.gypi	View	1 2 3 4	1 chunk	+1 line, -0 lines	0 comments	Download
M	webkit/tools/test_shell/test_shell.gypi	View	1 2	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 14 (0 generated)

Expand Messages | Collapse Messages

jamesr

lgtm What a coincidence - I commented out the CreateCmdBufferSkiaGLBinding() locally to try to get ...

8 years ago (2012-11-27 06:28:59 UTC) #2

piman

+ben for chrome_browser.gypi - just adding a missing dependency that was uncovered by changing a ...

8 years ago (2012-11-27 19:13:24 UTC) #3