sync: centralize sync startup decisions in TryStart.

chrome/browser/signin/token_service.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/signin/token_service.h"
 
 #include "base/basictypes.h"
 #include "base/command_line.h"
 #include "base/string_util.h"
 #include "chrome/browser/prefs/pref_service.h"
@@ skipping 173 matching lines @@
   content::NotificationService::current()->Notify(
       chrome::NOTIFICATION_TOKENS_CLEARED,
       content::Source<TokenService>(this),
       content::NotificationService::NoDetails());
 }
 
 bool TokenService::TokensLoadedFromDB() const {
   return tokens_loaded_;
 }
 
+void TokenService::set_tokens_loaded(bool loaded) {
+  tokens_loaded_ = loaded;
+}

[kochi, 2012/11/30 07:42:02]

Why not inline (define in header)?
(maybe this is just a preference, but I'm curious)

[tim (not reviewing), 2012/11/30 18:51:13]

No solid reason. I guess just overzealous application of
http://dev.chromium.org/developers/coding-style/cpp-dos-and-donts#TOC-Stop-in....
 I changed / inlined it.

+
 // static
 int TokenService::GetServiceIndex(const std::string& service) {
   for (size_t i = 0; i < arraysize(kServices); ++i) {
     if (kServices[i] == service)
       return i;
   }
   return -1;
 }
 
 bool TokenService::AreCredentialsValid() const {
@@ skipping 223 matching lines @@
   if (!in_memory_tokens->count(service) && db_tokens.count(service)) {
     std::string db_token = db_tokens.find(service)->second;
     if (!db_token.empty()) {
       VLOG(1) << "Loading " << service << " token from DB: " << db_token;
       (*in_memory_tokens)[service] = db_token;
       FireTokenAvailableNotification(service, db_token);
       // Failures are only for network errors.
     }
   }
 }