Issue 11348209: Fix JSON.stringify for objects with interceptor handlers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11348209: Fix JSON.stringify for objects with interceptor handlers. (Closed)

Created:
8 years, 1 month ago by Yang

Modified:
8 years, 1 month ago

Reviewers:
ulan_google, ulan

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Fix JSON.stringify for objects with interceptor handlers. BUG=161028 Committed: https://code.google.com/p/v8/source/detail?r=13041

Patch Set 1 #

Created: 8 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+28 lines, -33 lines)			Patch
	M	src/json-stringifier.h	View		3 chunks	+2 lines, -33 lines	0 comments	Download
	M	test/cctest/test-accessors.cc	View		1 chunk	+26 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Yang

This replaces v8::internal::BasicJsonStringifier::GetProperty with v8::internal::GetProperty. The former does a LookupRealNamedProperty, which fails for interceptor keys. ...

8 years, 1 month ago (2012-11-23 12:19:44 UTC) #1

LGTM

Expand Messages | Collapse Messages