Issue 11348202: Specify the test files to be used as an argument to the instrumentation tests

Issue 11348202: Specify the test files to be used as an argument to the instrumentation tests (Closed)

Created:
8 years, 1 month ago by aberent

Modified:
8 years, 1 month ago

Reviewers:
bulach, Anthony Berent

CC:
chromium-reviews, ilevy+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, peter+watch_chromium.org, klundberg+watch_chromium.org, frankf+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Specify the test files to be used as an argument to the instrumentation tests This allows different test sets to use different test data, and in particular allows new test sets, needing new data files, to be written without modifying the core test system. BUG=162395 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=169306

Patch Set 1 #

Patch Set 2 : Specify the test files to be used as an argument to the instrumentation tests #

Patch Set 3 : Specify the test files to be used as an argument to the instrumentation tests #

Total comments: 6

Patch Set 4 : Specify the test files to be used as an argument to the instrumentation tests - code review fixes #

Created: 8 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+22 lines, -11 lines)			Patch
M	build/android/buildbot/buildbot_functions.sh	View	1 2	2 chunks	+9 lines, -4 lines	0 comments	Download
M	build/android/pylib/run_java_tests.py	View	1 2 3	2 chunks	+5 lines, -6 lines	0 comments	Download
M	build/android/pylib/test_options_parser.py	View	1	1 chunk	+8 lines, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

bulach

lgtm, thanks! please put this through the FYI bots before CQing.. just some nits and ...

8 years, 1 month ago (2012-11-22 17:09:04 UTC) #2

Anthony Berent

https://codereview.chromium.org/11348202/diff/4001/build/android/pylib/run_java_tests.py File build/android/pylib/run_java_tests.py (right): https://codereview.chromium.org/11348202/diff/4001/build/android/pylib/run_java_tests.py#newcode166 build/android/pylib/run_java_tests.py:166: for copy_pair in self.test_data: On 2012/11/22 17:09:04, bulach wrote: ...

8 years, 1 month ago (2012-11-22 17:37:23 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aberent@chromium.org/11348202/4002

8 years, 1 month ago (2012-11-22 18:45:20 UTC) #4

Message was sent while issue was closed.

Change committed as 169306

Expand Messages | Collapse Messages