Free (and pause) audio resources when getting a phone call

media/base/android/java/src/org/chromium/media/MediaPlayerListener.java

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package org.chromium.media;
 
+import android.Manifest.permission;
 import android.content.Context;
 import android.content.pm.PackageManager;
-import android.Manifest.permission;
 import android.media.MediaPlayer;
+import android.telephony.PhoneStateListener;
+import android.telephony.TelephonyManager;
 
 import org.chromium.base.CalledByNative;
 import org.chromium.base.JNINamespace;
 
 // This class implements all the listener interface for android mediaplayer.
 // Callbacks will be sent to the native class for processing.
 @JNINamespace("media")
-class MediaPlayerListener implements MediaPlayer.OnPreparedListener,
-                                     MediaPlayer.OnCompletionListener,
-                                     MediaPlayer.OnBufferingUpdateListener,
-                                     MediaPlayer.OnSeekCompleteListener,
-                                     MediaPlayer.OnVideoSizeChangedListener,
-                                     MediaPlayer.OnErrorListener {
+class MediaPlayerListener extends PhoneStateListener implements MediaPlayer.OnPreparedListener,

[Yaron, 2012/11/27 05:58:00]

What about composing a PhoneStateListener. Then each class is only covering one
aspect.

[Miguel Garcia, 2012/11/27 17:24:06]

I kind of like the idea of having a single class that worries about all the
reasons that will cause pausing the player without user intervention. Before all
listed reasons came from MediaPlayer but unless they grow much more it's nice to
have them all in a single place instead of spread around the code base.

If you feel strongly about it I'll change it of course. I am still a guest here
:)


On 2012/11/27 05:58:00, Yaron wrote:

[Yaron, 2012/11/27 18:12:25]

I was thinking an inner class (and thus not very far away) but I don't feel
overly strongly about it.

+    MediaPlayer.OnCompletionListener,
+    MediaPlayer.OnBufferingUpdateListener,
+    MediaPlayer.OnSeekCompleteListener,
+    MediaPlayer.OnVideoSizeChangedListener,
+    MediaPlayer.OnErrorListener {
     // These values are mirrored as enums in media/base/android/media_player_bridge.h.
     // Please ensure they stay in sync.
     private static final int MEDIA_ERROR_FORMAT = 0;
     private static final int MEDIA_ERROR_DECODE = 1;
     private static final int MEDIA_ERROR_NOT_VALID_FOR_PROGRESSIVE_PLAYBACK = 2;
     private static final int MEDIA_ERROR_INVALID_CODE = 3;
 
     // These values are copied from android media player.
     public static final int MEDIA_ERROR_MALFORMED = -1007;
     public static final int MEDIA_ERROR_TIMED_OUT = -110;
 
     // Used to determine the class instance to dispatch the native call to.
     private int mNativeMediaPlayerListener = 0;
+    private final Context mContext;
 
-    private MediaPlayerListener(int nativeMediaPlayerListener) {
+    private MediaPlayerListener(int nativeMediaPlayerListener, Context context) {
         mNativeMediaPlayerListener = nativeMediaPlayerListener;
+        mContext = context;
     }
 
     @Override
     public boolean onError(MediaPlayer mp, int what, int extra) {
         int errorType;
         switch (what) {
             case MediaPlayer.MEDIA_ERROR_UNKNOWN:
                 switch (extra) {
                     case MEDIA_ERROR_MALFORMED:
                         errorType = MEDIA_ERROR_DECODE;
@@ skipping 42 matching lines @@
     @Override
     public void onCompletion(MediaPlayer mp) {
         nativeOnPlaybackComplete(mNativeMediaPlayerListener);
     }
 
     @Override
     public void onPrepared(MediaPlayer mp) {
         nativeOnMediaPrepared(mNativeMediaPlayerListener);
     }
 
+    @Override
+    public void onCallStateChanged(int type, String number) {
+        if (type != TelephonyManager.CALL_STATE_IDLE) {
+            nativeOnMediaInterrupted(mNativeMediaPlayerListener);
+        }
+    }
+
     @CalledByNative
-    private static void create(int nativeMediaPlayerListener,
+    public void releaseResources() {
+        // Unregister the listener
+        if (mContext != null) {
+            TelephonyManager mgr =
+                    (TelephonyManager) mContext.getSystemService(Context.TELEPHONY_SERVICE);
+            if (mgr != null) {
+                mgr.listen(this, PhoneStateListener.LISTEN_NONE);
+            }
+        }
+    }
+
+    @CalledByNative
+    private static MediaPlayerListener create(int nativeMediaPlayerListener,
             Context context, MediaPlayer mediaPlayer) {
-        MediaPlayerListener listener = new MediaPlayerListener(nativeMediaPlayerListener);
+        MediaPlayerListener listener = new MediaPlayerListener(nativeMediaPlayerListener, context);
         mediaPlayer.setOnBufferingUpdateListener(listener);
         mediaPlayer.setOnCompletionListener(listener);
         mediaPlayer.setOnErrorListener(listener);
         mediaPlayer.setOnPreparedListener(listener);
         mediaPlayer.setOnSeekCompleteListener(listener);
         mediaPlayer.setOnVideoSizeChangedListener(listener);
         if (PackageManager.PERMISSION_GRANTED ==
                 context.checkCallingPermission(permission.WAKE_LOCK)) {
             mediaPlayer.setWakeMode(context, android.os.PowerManager.FULL_WAKE_LOCK);
         }
+
+        TelephonyManager mgr =
+                (TelephonyManager) context.getSystemService(Context.TELEPHONY_SERVICE);
+        if (mgr != null) {
+            mgr.listen(listener, PhoneStateListener.LISTEN_CALL_STATE);
+        }
+        return listener;
     }
 
     /**
      * See media/base/android/media_player_listener.cc for all the following functions.
      */
     private native void nativeOnMediaError(
             int nativeMediaPlayerListener,
             int errorType);
 
     private native void nativeOnVideoSizeChanged(
             int nativeMediaPlayerListener,
             int width, int height);
 
     private native void nativeOnBufferingUpdate(
             int nativeMediaPlayerListener,
             int percent);
 
     private native void nativeOnMediaPrepared(int nativeMediaPlayerListener);
 
     private native void nativeOnPlaybackComplete(int nativeMediaPlayerListener);
 
     private native void nativeOnSeekComplete(int nativeMediaPlayerListener);
+
+    private native void nativeOnMediaInterrupted(int nativeMediaPlayerListener);
 }