Fix ASAN issue in ActionBoxTest

Fix ASAN issue in ActionBoxTest



BUG=


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=169077

[Cait (Slow), 2012-11-20 15:32:08]

Hi Scott -- PTAL, this change fixes an ASAN flake caused by this test.

Thanks,
Cait

[sky, 2012-11-20 16:56:40]

Its my understanding ActionBox is going away. I'm not sure why that hasn't been
done yet. Yefim?

[Cait (Slow), 2012-11-20 18:39:27]

On 2012/11/20 16:56:40, sky wrote:
> Its my understanding ActionBox is going away. I'm not sure why that hasn't
been
> done yet. Yefim?

I wasn't sure if ActionBox was going away or on hold until the UX got an
overhaul. If it's going away for sure, I'll remove the tests, but I didn't want
to do so until the code they are testing went away too.

[sky, 2012-11-20 19:27:47]

On 2012/11/20 18:39:27, caitkp wrote:
> On 2012/11/20 16:56:40, sky wrote:
> > Its my understanding ActionBox is going away. I'm not sure why that hasn't
> been
> > done yet. Yefim?
> 
> I wasn't sure if ActionBox was going away or on hold until the UX got an
> overhaul. If it's going away for sure, I'll remove the tests, but I didn't
want
> to do so until the code they are testing went away too.

crbug.com/159138 . When I asked Ben about this he was under the impression we
were getting rid of it all.

[yefimt, 2012-11-20 19:30:22]

Yes Action box is going away but PM asked me to hold on action box code removal
for a few days.

On 2012/11/20 19:27:47, sky wrote:
> On 2012/11/20 18:39:27, caitkp wrote:
> > On 2012/11/20 16:56:40, sky wrote:
> > > Its my understanding ActionBox is going away. I'm not sure why that hasn't
> > been
> > > done yet. Yefim?
> > 
> > I wasn't sure if ActionBox was going away or on hold until the UX got an
> > overhaul. If it's going away for sure, I'll remove the tests, but I didn't
> want
> > to do so until the code they are testing went away too.
> 
> crbug.com/159138 . When I asked Ben about this he was under the impression we
> were getting rid of it all.

[stromme, 2012-11-20 23:34:31]

Sounds like I needed to move a little quicker. We have rethought the action box
and will be keeping most of the UI-related code to at least try out this
redesign. The web intents parts can be removed, but I'd appreciate if the UI
parts could stay (behind the flag).

[sky, 2012-11-21 00:49:22]

LGTM

[commit-bot: I haz the power, 2012-11-21 16:27:21]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/caitkp@chromium.org/11348143/1

[commit-bot: I haz the power, 2012-11-21 18:15:30]

Change committed as 169077