Add presubmit check to verify issue is not closed.

tests/presubmit_unittest.py

Index: tests/presubmit_unittest.py
diff --git a/tests/presubmit_unittest.py b/tests/presubmit_unittest.py
index cf449dcc83fe0569926c41c6e786233c06cf901d..8ca472d7068819eb8259d4f33061671515c3c9f3 100755
--- a/tests/presubmit_unittest.py
+++ b/tests/presubmit_unittest.py
@@ -1507,6 +1507,7 @@ class CannedChecksUnittest(PresubmitTestsBase):
       'CheckLongLines', 'CheckTreeIsOpen', 'PanProjectChecks',
       'CheckLicense',
       'CheckOwners',
+      'CheckIssueNotClosed',
       'CheckRietveldTryJobExecution',
       'CheckSingletonInHeaders',
       'CheckSvnModifiedDirectories',
@@ -2394,6 +2395,26 @@ class CannedChecksUnittest(PresubmitTestsBase):
                            is_committing=False,
                            uncovered_dirs=set())
 
+  def IssueStateChecksBase(self, closed):
+    input_api = self.MockInputApi(
+        presubmit.Change('', '', '.', [], 0, 0, None),
+        False)
+    input_api.rietveld.get_issue_properties(
+        issue=int(input_api.change.issue),
+        messages=False).AndReturn({'closed': closed})
+    self.mox.ReplayAll()
+    return presubmit_canned_checks.CheckIssueNotClosed(
+        input_api,
+        presubmit.OutputApi)
+
+  def testIssueOpen(self):
+    self.assertEqual([], self.IssueStateChecksBase(closed=False))
+
+  def testIssueClosed(self):
+    results = self.IssueStateChecksBase(closed=True)
+    self.assertEqual(len(results), 1)
+    self.assertTrue(results[0].fatal)
+    
   def testCannedRunUnitTests(self):
     change = presubmit.Change(
         'foo1', 'description1', self.fake_root_dir, None, 0, 0, None)
@@ -2470,6 +2491,9 @@ class CannedChecksUnittest(PresubmitTestsBase):
     input_api.AffectedSourceFiles(mox.IgnoreArg()).AndReturn([affected_file])
     input_api.ReadFile(affected_file).AndReturn('Hey!\nHo!\nHey!\nHo!\n\n')
     input_api.AffectedSourceFiles(mox.IgnoreArg()).AndReturn([affected_file])
+    input_api.rietveld.get_issue_properties(
+        issue=int(input_api.change.issue),
+        messages=False).AndReturn({'closed': False})
     for _ in range(4):
       affected_file.LocalPath().AndReturn('hello.py')