Add presubmit check to verify issue is not closed.

tests/presubmit_unittest.py

 #!/usr/bin/env python
 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Unit tests for presubmit_support.py and presubmit_canned_checks.py."""
 
 # pylint: disable=E1101,E1103
 
 import logging
@@ skipping 1489 matching lines @@
       'CheckChangeHasQaField', 'CheckChangeHasTestedField',
       'CheckChangeHasTestField',
       'CheckChangeLintsClean',
       'CheckChangeSvnEolStyle',
       'CheckChangeWasUploaded',
       'CheckDoNotSubmit',
       'CheckDoNotSubmitInDescription', 'CheckDoNotSubmitInFiles',
       'CheckLongLines', 'CheckTreeIsOpen', 'PanProjectChecks',
       'CheckLicense',
       'CheckOwners',
+      'CheckIssueNotClosed',
       'CheckRietveldTryJobExecution',
       'CheckSingletonInHeaders',
       'CheckSvnModifiedDirectories',
       'CheckSvnForCommonMimeTypes', 'CheckSvnProperty',
       'RunPythonUnitTests', 'RunPylint',
       'RunUnitTests', 'RunUnitTestsInDirectory',
     ]
     # If this test fails, you should add the relevant test.
     self.compareMembers(presubmit_canned_checks, members)
 
@@ skipping 726 matching lines @@
           "reviewers": reviewers
         }
 
       if is_committing:
         people = approvers
       else:
         people = reviewers
 
       if issue:
         input_api.rietveld.get_issue_properties(
-            int(input_api.change.issue), True).AndReturn(rietveld_response)
+            issue=int(input_api.change.issue), messages=True).AndReturn(
+                rietveld_response)
         people.add(owner_email)
 
       fake_db.directories_not_covered_by(set(['foo/xyz.cc']),
           people).AndReturn(uncovered_dirs)
       if not is_committing and uncovered_dirs:
         fake_db.reviewers_for(set(['foo/xyz.cc'])).AndReturn(owner_email)
 
     self.mox.ReplayAll()
     output = presubmit.PresubmitOutput()
     results = presubmit_canned_checks.CheckOwners(input_api,
@@ skipping 120 matching lines @@
                         'directories:\n'
                         '    foo\n')
 
   def testCannedCheckOwners_WithLGTMs(self):
     self.AssertOwnersWorks(approvers=set(['ben@example.com']),
                            uncovered_dirs=set())
     self.AssertOwnersWorks(approvers=set(['ben@example.com']),
                            is_committing=False,
                            uncovered_dirs=set())
 
+  def CheckIssueClosedBase(self, closed):
+    input_api = self.MockInputApi(
+        presubmit.Change('', '', None, None, 1, 0, None), False)
+    input_api.rietveld.get_issue_properties(
+        issue=int(input_api.change.issue), messages=False).AndReturn(
+            {'closed': closed, 'issue': 1})
+    self.mox.ReplayAll()
+    return presubmit_canned_checks.CheckIssueNotClosed(
+        input_api, presubmit.OutputApi)
+
+  def testIssueOpen(self):
+    self.assertEqual([], self.CheckIssueClosedBase(False))
+
+  def testIssueClosed(self):
+    results = self.CheckIssueClosedBase(True)
+    self.assertEqual(len(results), 1)
+    self.assertTrue(results[0].fatal)
+
   def testCannedRunUnitTests(self):
     change = presubmit.Change(
         'foo1', 'description1', self.fake_root_dir, None, 0, 0, None)
     input_api = self.MockInputApi(change, False)
     input_api.verbose = True
     unit_tests = ['allo', 'bar.py']
     input_api.PresubmitLocalPath().AndReturn(self.fake_root_dir)
     input_api.PresubmitLocalPath().AndReturn(self.fake_root_dir)
     input_api.subprocess.check_call(
         ['allo', '--verbose'], cwd=self.fake_root_dir)
@@ skipping 77 matching lines @@
         owners_check=False)
     self.assertEqual(1, len(results))
     self.assertEqual(
         'Found line ending with white spaces in:', results[0]._message)
     self.checkstdout('')
 
 
 if __name__ == '__main__':
   import unittest
   unittest.main()