Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(196)

Side by Side Diff: scripts/master/factory/commands.py

Issue 11348094: A testfilter with 'compile' will trigger to build everything. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/build
Patch Set: Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 """Set of utilities to add commands to a buildbot factory (BuildFactory). 5 """Set of utilities to add commands to a buildbot factory (BuildFactory).
6 6
7 All the utility functions to add steps to a build factory here are not 7 All the utility functions to add steps to a build factory here are not
8 project-specific. See the other *_commands.py for project-specific commands. 8 project-specific. See the other *_commands.py for project-specific commands.
9 """ 9 """
10 10
(...skipping 117 matching lines...) Expand 10 before | Expand all | Expand 10 after
128 class CompileWithRequiredSwarmTargets(shell.Compile): 128 class CompileWithRequiredSwarmTargets(shell.Compile):
129 def start(self): 129 def start(self):
130 try: 130 try:
131 test_filters = self.getProperty('testfilter') 131 test_filters = self.getProperty('testfilter')
132 except KeyError: 132 except KeyError:
133 test_filters = [] 133 test_filters = []
134 134
135 command = self.command 135 command = self.command
136 swarm_tests = GetSwarmTestsFromTestFilter(test_filters) 136 swarm_tests = GetSwarmTestsFromTestFilter(test_filters)
137 command.extend(swarm_test + '_run' for swarm_test in swarm_tests) 137 command.extend(swarm_test + '_run' for swarm_test in swarm_tests)
138 if 'compile' in test_filters:
139 command.append('all')
138 140
139 self.setCommand(command) 141 self.setCommand(command)
140 return shell.Compile.start(self) 142 return shell.Compile.start(self)
141 143
142 144
143 class FactoryCommands(object): 145 class FactoryCommands(object):
144 # Base URL for performance test results. 146 # Base URL for performance test results.
145 PERF_BASE_URL = config.Master.perf_base_url 147 PERF_BASE_URL = config.Master.perf_base_url
146 PERF_REPORT_URL_SUFFIX = config.Master.perf_report_url_suffix 148 PERF_REPORT_URL_SUFFIX = config.Master.perf_report_url_suffix
147 149
(...skipping 948 matching lines...) Expand 10 before | Expand all | Expand 10 after
1096 1098
1097 def commandComplete(self, cmd): 1099 def commandComplete(self, cmd):
1098 out = cmd.logs['stdio'].getText() 1100 out = cmd.logs['stdio'].getText()
1099 build_properties = re.findall('BUILD_PROPERTY ([^=]*)=(.*)', out) 1101 build_properties = re.findall('BUILD_PROPERTY ([^=]*)=(.*)', out)
1100 for propname, value in build_properties: 1102 for propname, value in build_properties:
1101 # findall can return strings containing CR characters, remove with strip. 1103 # findall can return strings containing CR characters, remove with strip.
1102 self.build.setProperty(propname, value.strip(), 'Step') 1104 self.build.setProperty(propname, value.strip(), 'Step')
1103 1105
1104 def getText(self, cmd, results): 1106 def getText(self, cmd, results):
1105 return self.describe(True) + self.messages 1107 return self.describe(True) + self.messages
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698