Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(13)

Issue 11348025: Fix GenerateIndex for gsutil directories by stripping colon off directory names. (Closed)

Created:
7 years, 1 month ago by navabi
Modified:
7 years, 1 month ago
CC:
chromium-reviews
Visibility:
Public.

Description

Fix GenerateIndex for gsutil directories by stripping colon off directory names. The gsutil ls -L will recursively list the contents of a directory. Subdirectories are listed with a ':' after them like this: 'subdir/:' with their contents listed under it. When recursing gsutil will fail on directories that end with '/:'. This CL strips the colon from that output. Also looked into: gsutil ls -r (and -R) dir: still puts the colon at the end gsutil ls -L dir/** (for flat listing): does not list sub directories at all; only shows the files. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=164784

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M gsd_generate_index.py View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
navabi1
7 years, 1 month ago (2012-10-29 23:46:26 UTC) #1
Isaac (away)
lgtm with python style nit. https://codereview.chromium.org/11348025/diff/1/gsd_generate_index.py File gsd_generate_index.py (right): https://codereview.chromium.org/11348025/diff/1/gsd_generate_index.py#newcode174 gsd_generate_index.py:174: objects = map(strip_colon, objects) ...
7 years, 1 month ago (2012-10-29 23:49:23 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/navabi@google.com/11348025/4
7 years, 1 month ago (2012-10-29 23:58:15 UTC) #3
commit-bot: I haz the power
7 years, 1 month ago (2012-10-29 23:58:20 UTC) #4
Change committed as 164784

Powered by Google App Engine
This is Rietveld 408576698