Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Issue 11347022: cc: Reduce number of partial resource updates. (Closed)

Created:
8 years, 1 month ago by reveman
Modified:
8 years, 1 month ago
Reviewers:
epenner, nduca
CC:
chromium-reviews
Visibility:
Public.

Description

cc: Disable partial resource updates on Android. This makes partialTextureUpdatesMax constant 0 when building for OS_ANDROID. BUG=156945 TEST=manual Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=166347

Patch Set 1 #

Patch Set 2 : Keep desktop at 12 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M cc/resource_update_controller.cc View 1 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
reveman
8 years, 1 month ago (2012-10-29 20:02:15 UTC) #1
nduca
Why? Benchmarks that back up the win? No changes without benchmarks. If the benchmark doesn't ...
8 years, 1 month ago (2012-11-05 06:52:38 UTC) #2
reveman
On 2012/11/05 06:52:38, nduca wrote: > Why? Benchmarks that back up the win? No changes ...
8 years, 1 month ago (2012-11-05 18:14:37 UTC) #3
epennerAtGoogle
We have hard data from driver vendors that partial updates are bad. Here's the two ...
8 years, 1 month ago (2012-11-05 20:51:41 UTC) #4
nduca
lgtm if you keep desktop at 12.
8 years, 1 month ago (2012-11-06 20:14:11 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/reveman@chromium.org/11347022/7001
8 years, 1 month ago (2012-11-07 00:05:33 UTC) #6
commit-bot: I haz the power
8 years, 1 month ago (2012-11-07 04:40:14 UTC) #7
Change committed as 166347

Powered by Google App Engine
This is Rietveld 408576698