Move remaining content test code into the content namespace.

Move remaining content test code into the content namespace.
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=164789

[tfarina, 2012-10-29 21:01:30]

lgtm

just the usual nits, just ignore them.

https://chromiumcodereview.appspot.com/11346016/diff/17002/chrome/browser/acc...
File chrome/browser/accessibility/accessibility_win_browsertest.cc (right):

https://chromiumcodereview.appspot.com/11346016/diff/17002/chrome/browser/acc...
chrome/browser/accessibility/accessibility_win_browsertest.cc:354:
content::IAccessible2RoleToString(ia2_role_);
do we want to add a 'using' declaration instead?

https://chromiumcodereview.appspot.com/11346016/diff/17002/chrome/browser/net...
File chrome/browser/net/url_request_mock_util.cc (right):

https://chromiumcodereview.appspot.com/11346016/diff/17002/chrome/browser/net...
chrome/browser/net/url_request_mock_util.cc:37:
content::URLRequestFailedJob::AddUrlHandler();
want to go with using declaration instead?

https://chromiumcodereview.appspot.com/11346016/diff/17002/content/browser/si...
File content/browser/site_instance_impl_unittest.cc (right):

https://chromiumcodereview.appspot.com/11346016/diff/17002/content/browser/si...
content/browser/site_instance_impl_unittest.cc:39: : public
WebUIControllerFactory {
it fits above.

https://chromiumcodereview.appspot.com/11346016/diff/17002/content/public/tes...
File content/public/test/mock_render_process_host.cc (right):

https://chromiumcodereview.appspot.com/11346016/diff/17002/content/public/tes...
content/public/test/mock_render_process_host.cc:265: }  // content
nit: namespace content

https://chromiumcodereview.appspot.com/11346016/diff/17002/content/public/tes...
File content/public/test/mock_render_thread.cc (right):

https://chromiumcodereview.appspot.com/11346016/diff/17002/content/public/tes...
content/public/test/mock_render_thread.cc:126: RenderProcessObserver* observer)
{
now it fits above.

https://chromiumcodereview.appspot.com/11346016/diff/17002/content/test/layou...
File content/test/layout_browsertest.h (right):

https://chromiumcodereview.appspot.com/11346016/diff/17002/content/test/layou...
content/test/layout_browsertest.h:10: namespace content {
newline between 9-10.

https://chromiumcodereview.appspot.com/11346016/diff/17002/content/test/net/u...
File content/test/net/url_request_mock_http_job.cc (right):

https://chromiumcodereview.appspot.com/11346016/diff/17002/content/test/net/u...
content/test/net/url_request_mock_http_job.cc:32: namespace content {
wrap the unnamed namespace into content namespace too? I'd move this above to
line 17 and move the constants into the unnamed namespace too.

https://chromiumcodereview.appspot.com/11346016/diff/17002/content/test/net/u...
File content/test/net/url_request_slow_download_job.h (right):

https://chromiumcodereview.appspot.com/11346016/diff/17002/content/test/net/u...
content/test/net/url_request_slow_download_job.h:4: // This class simulates a
slow download.  This used in a UI test to test the
sorry for pointing this out, but I hate comments like this at the top of the
file right after the copyright license. :(

I'd prefer if it was right before the class declaration.

https://chromiumcodereview.appspot.com/11346016/diff/17002/content/test/net/u...
File content/test/net/url_request_slow_http_job.cc (right):

https://chromiumcodereview.appspot.com/11346016/diff/17002/content/test/net/u...
content/test/net/url_request_slow_http_job.cc:11: static const char
kMockHostname[] = "mock.slow.http";
nit: I'd move into the unnamed namespace, but that is out of the scoped of this
CL :(

https://chromiumcodereview.appspot.com/11346016/diff/17002/content/test/test_...
File content/test/test_render_view_host_factory.h (right):

https://chromiumcodereview.appspot.com/11346016/diff/17002/content/test/test_...
content/test/test_render_view_host_factory.h:26: RenderProcessHostFactory*
rph_factory);
fits above.

https://chromiumcodereview.appspot.com/11346016/diff/17002/content/test/test_...
content/test/test_render_view_host_factory.h:29: virtual void
set_render_process_host_factory(
this should have been SetRender...

https://chromiumcodereview.appspot.com/11346016/diff/17002/content/test/test_...
File content/test/test_web_contents_view.cc (right):

https://chromiumcodereview.appspot.com/11346016/diff/17002/content/test/test_...
content/test/test_web_contents_view.cc:16: const ContextMenuParams& params,
fits above.

https://chromiumcodereview.appspot.com/11346016/diff/17002/content/test/test_...
File content/test/test_web_contents_view.h (right):

https://chromiumcodereview.appspot.com/11346016/diff/17002/content/test/test_...
content/test/test_web_contents_view.h:22: const ContextMenuParams& params,
fits above.

[jam, 2012-10-29 23:48:07]

https://chromiumcodereview.appspot.com/11346016/diff/17002/content/browser/si...
File content/browser/site_instance_impl_unittest.cc (right):

https://chromiumcodereview.appspot.com/11346016/diff/17002/content/browser/si...
content/browser/site_instance_impl_unittest.cc:39: : public
WebUIControllerFactory {
On 2012/10/29 21:01:30, tfarina wrote:
> it fits above.

Done.

https://chromiumcodereview.appspot.com/11346016/diff/17002/content/public/tes...
File content/public/test/mock_render_thread.cc (right):

https://chromiumcodereview.appspot.com/11346016/diff/17002/content/public/tes...
content/public/test/mock_render_thread.cc:126: RenderProcessObserver* observer)
{
On 2012/10/29 21:01:30, tfarina wrote:
> now it fits above.

Done.

https://chromiumcodereview.appspot.com/11346016/diff/17002/content/test/layou...
File content/test/layout_browsertest.h (right):

https://chromiumcodereview.appspot.com/11346016/diff/17002/content/test/layou...
content/test/layout_browsertest.h:10: namespace content {
On 2012/10/29 21:01:30, tfarina wrote:
> newline between 9-10.

Done.

https://chromiumcodereview.appspot.com/11346016/diff/17002/content/test/test_...
File content/test/test_render_view_host_factory.h (right):

https://chromiumcodereview.appspot.com/11346016/diff/17002/content/test/test_...
content/test/test_render_view_host_factory.h:26: RenderProcessHostFactory*
rph_factory);
On 2012/10/29 21:01:30, tfarina wrote:
> fits above.

Done.