Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(505)

Issue 11346007: Add build/android scripts for Chromium TestShell (Closed)

Created:
8 years, 1 month ago by mnaganov (inactive)
Modified:
8 years, 1 month ago
Reviewers:
bulach, digit1
CC:
chromium-reviews, peter+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy+watch_chromium.org
Visibility:
Public.

Description

Add build/android scripts for Chromium TestShell This is to match existing scripts for Content Shell. There seem to be inconsistency in usages of 'testshell' vs. 'test_shell'. Since the build target is called 'chromium_testshell', and the package is called 'org.chromium.chrome.testshell', I'm leaning towards using this spelling. R=digit@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=164808

Patch Set 1 #

Patch Set 2 : Use testshell uniformly #

Total comments: 2

Patch Set 3 : Fix script location #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -26 lines) Patch
A + build/android/adb_chromium_testshell_command_line View 1 2 chunks +9 lines, -9 lines 0 comments Download
D build/android/adb_gdb_chromium_test_shell View 1 1 chunk +0 lines, -16 lines 0 comments Download
A + build/android/adb_gdb_chromium_testshell View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A + build/android/adb_run_chromium_testshell View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/testshell/java/src/org/chromium/chrome/testshell/ChromiumTestShellActivity.java View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
mnaganov (inactive)
8 years, 1 month ago (2012-10-29 12:38:54 UTC) #1
digit1
https://codereview.chromium.org/11346007/diff/2001/adb_gdb_chromium_testshell File adb_gdb_chromium_testshell (right): https://codereview.chromium.org/11346007/diff/2001/adb_gdb_chromium_testshell#newcode1 adb_gdb_chromium_testshell:1: #!/bin/bash Are you sure you want to add/move this ...
8 years, 1 month ago (2012-10-29 17:43:33 UTC) #2
mnaganov (inactive)
https://codereview.chromium.org/11346007/diff/2001/adb_gdb_chromium_testshell File adb_gdb_chromium_testshell (right): https://codereview.chromium.org/11346007/diff/2001/adb_gdb_chromium_testshell#newcode1 adb_gdb_chromium_testshell:1: #!/bin/bash On 2012/10/29 17:43:33, digit1 wrote: > Are you ...
8 years, 1 month ago (2012-10-29 17:47:53 UTC) #3
digit1
lgtm :)
8 years, 1 month ago (2012-10-29 18:09:08 UTC) #4
mnaganov (inactive)
+Marcus for changes in 'chrome/android/'
8 years, 1 month ago (2012-10-29 18:11:07 UTC) #5
bulach
lgtm, thanks!
8 years, 1 month ago (2012-10-29 18:44:38 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mnaganov@chromium.org/11346007/7001
8 years, 1 month ago (2012-10-29 21:37:54 UTC) #7
commit-bot: I haz the power
8 years, 1 month ago (2012-10-30 01:07:41 UTC) #8
Change committed as 164808

Powered by Google App Engine
This is Rietveld 408576698