Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(847)

Issue 11346006: Use 1 instead of 0 for changestamp at unittest. (Closed)

Created:
8 years, 1 month ago by kochi
Modified:
8 years, 1 month ago
Reviewers:
kinaba
CC:
chromium-reviews, achuith+watch_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

Use 1 instead of 0 for changestamp at unittest. As 0 has some special meaning (not initialized), change to use 1 for the old changestamp. BUG=none TEST=pass unit_tests --gtest_filter="DriveFilsSystemTest.*" Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=164847

Patch Set 1 #

Patch Set 2 : Use 1 for changestamp. #

Patch Set 3 : Remove unnecessary setup, move EXPECT_CALL(OnDirectoryChanged) to appropriate position. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -7 lines) Patch
M chrome/browser/chromeos/drive/drive_file_system_unittest.cc View 1 2 4 chunks +7 lines, -7 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
kochi
Hi Kazuhiro, Could you review this?
8 years, 1 month ago (2012-10-29 08:46:13 UTC) #1
kinaba
lgtm
8 years, 1 month ago (2012-10-29 09:20:42 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kochi@chromium.org/11346006/5001
8 years, 1 month ago (2012-10-29 12:53:56 UTC) #3
commit-bot: I haz the power
Retried try job too often for step(s) browser_tests
8 years, 1 month ago (2012-10-29 16:57:01 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kochi@chromium.org/11346006/5001
8 years, 1 month ago (2012-10-30 01:11:11 UTC) #5
commit-bot: I haz the power
8 years, 1 month ago (2012-10-30 04:56:52 UTC) #6
Change committed as 164847

Powered by Google App Engine
This is Rietveld 408576698