Implemented BluetoothAdapterWin::IsPresent().

device/bluetooth/bluetooth_adapter_win.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 //
 // TODO(youngki): Implement this file.
 
 #include "device/bluetooth/bluetooth_adapter_win.h"
 
+#include <BluetoothAPIs.h>
 #include <string>
 #include "base/logging.h"
+#include "base/message_loop.h"
+#include "base/stringprintf.h"
+#include "base/sys_string_conversions.h"
+
+# pragma comment(lib, "Bthprops.lib")
+
+namespace {
+  const BLUETOOTH_FIND_RADIO_PARAMS bluetooth_adapter_param =

[bryeung, 2012/10/30 19:58:40]

no indent and a blank line after namespace and before the closing namespace
brace

[youngki, 2012/10/30 21:50:56]

Done.

+      { sizeof(BLUETOOTH_FIND_RADIO_PARAMS) };
+
+  const int kUpdateAdapterStateIntervalMs = 500;
+}  // namespace
 
 namespace device {
 
 BluetoothAdapterWin::BluetoothAdapterWin()
     : BluetoothAdapter(),
       ALLOW_THIS_IN_INITIALIZER_LIST(weak_ptr_factory_(this)) {
 }
 
 BluetoothAdapterWin::~BluetoothAdapterWin() {
 }
 
 void BluetoothAdapterWin::AddObserver(BluetoothAdapter::Observer* observer) {
   NOTIMPLEMENTED();
 }
 
 void BluetoothAdapterWin::RemoveObserver(BluetoothAdapter::Observer* observer) {
   NOTIMPLEMENTED();
 }
 
 bool BluetoothAdapterWin::IsPresent() const {

[bryeung, 2012/10/30 19:58:40]

This should probably try to update address_ immediately before returning.

[youngki, 2012/10/30 21:50:56]

This is a const method.. so I don't think we can update address_ here.

-  NOTIMPLEMENTED();
-  return false;
+  return !address_.empty();
 }
 
 bool BluetoothAdapterWin::IsPowered() const {
   NOTIMPLEMENTED();
   return false;
 }
 
 void BluetoothAdapterWin::SetPowered(
     bool powered,
     const base::Closure& callback,
@@ skipping 28 matching lines @@
   NOTIMPLEMENTED();
   return NULL;
 }
 
 void BluetoothAdapterWin::ReadLocalOutOfBandPairingData(
     const BluetoothOutOfBandPairingDataCallback& callback,
     const ErrorCallback& error_callback) {
   NOTIMPLEMENTED();
 }
 
+void BluetoothAdapterWin::TrackDefaultAdapter() {
+  UpdateAdapterState();

[bryeung, 2012/10/30 19:58:40]

This is going to start polling before it is necessary.

There are two changes to fix this:
1) Make ExtensionBluetoothEventRouter lazily initialize the adapter.  That can
be done here, or in a prequel CL.  Should be fairly straightforward.

2) Avoid calling TrackDefaultAdapter (on Windows) until there are actually event
listeners waiting for events.  This requires a bit of a change in semantics, but
I think it makes sense in order to prevent unnecessary polling.

Scott: thoughts?

[youngki, 2012/10/30 21:50:56]

I will wait for Scott's thoughts here.

[keybuk, 2012/10/31 18:19:47]

TrackDefaultAdapter should only be called when a new default adapter instance is
created, and that should only happen when a class (like the settings page) calls
for it.

Likewise when nothing requires it (settings page is closed), the default adapter
should be cleaned up.

So polling will open happen during need anyway, no?

[bryeung, 2012/10/31 18:46:01]

Maybe this is strictly a problem with ExtensionBluetoothEventRouter then (in
that it is holding on to the adapter reference for too long).

We'll fix it there and then hopefully this is okay.

[youngki, 2012/10/31 19:42:59]

Okay then I will leave this as it is for now.

+}
+
+void BluetoothAdapterWin::UpdateAdapterState() {
+  HBLUETOOTH_RADIO_FIND bluetooth_adapter_handle = NULL;
+  BLUETOOTH_RADIO_INFO bluetooth_adapter_info =
+      { sizeof(BLUETOOTH_RADIO_INFO), 0 };
+  BluetoothFindFirstRadio(&bluetooth_adapter_param, &bluetooth_adapter_handle);
+  if (bluetooth_adapter_handle &&
+      ERROR_SUCCESS == BluetoothGetRadioInfo(bluetooth_adapter_handle,
+                                             &bluetooth_adapter_info)) {
+    name_ = base::SysWideToUTF8(bluetooth_adapter_info.szName);
+    address_ = base::StringPrintf("%02X:%02X:%02X:%02X:%02X:%02X",
+        bluetooth_adapter_info.address.rgBytes[5],
+        bluetooth_adapter_info.address.rgBytes[4],
+        bluetooth_adapter_info.address.rgBytes[3],
+        bluetooth_adapter_info.address.rgBytes[2],
+        bluetooth_adapter_info.address.rgBytes[1],
+        bluetooth_adapter_info.address.rgBytes[0]);
+  } else {
+    name_.clear();
+    address_.clear();
+  }
+
+  MessageLoop::current()->PostDelayedTask(
+      FROM_HERE,
+      base::Bind(&BluetoothAdapterWin::UpdateAdapterState,
+                 weak_ptr_factory_.GetWeakPtr()),
+      base::TimeDelta::FromMilliseconds(kUpdateAdapterStateIntervalMs));
+}
+
 }  // namespace device