chrome/browser/prefs/scoped_user_pref_update_unittest.cc - Issue 11345008: Remove content::NotificationObserver dependency from most Prefs code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/prefs/scoped_user_pref_update_unittest.cc

Issue 11345008: Remove content::NotificationObserver dependency from most Prefs code. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Merge to head for commit Created 8 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/prefs/scoped_user_pref_update_unittest.cc

diff --git a/chrome/browser/prefs/scoped_user_pref_update_unittest.cc b/chrome/browser/prefs/scoped_user_pref_update_unittest.cc

index 98ffc894199deec2b483c424f8435d9df16e264c..f5e6927bd0b2c7260f160df1beb6d952d8784b21 100644

--- a/chrome/browser/prefs/scoped_user_pref_update_unittest.cc

+++ b/chrome/browser/prefs/scoped_user_pref_update_unittest.cc

@@ -42,7 +42,7 @@ TEST_F(ScopedUserPrefUpdateTest, RegularUse) {

expected_dictionary.SetString(kKey, kValue);

{

- EXPECT_CALL(observer_, Observe(_, _, _)).Times(0);

+ EXPECT_CALL(observer_, OnPreferenceChanged(_, _)).Times(0);

DictionaryPrefUpdate update(&prefs_, kPref);

DictionaryValue* value = update.Get();

ASSERT_TRUE(value);

@@ -69,7 +69,7 @@ TEST_F(ScopedUserPrefUpdateTest, RegularUse) {

TEST_F(ScopedUserPrefUpdateTest, NeverTouchAnything) {

const DictionaryValue* old_value = prefs_.GetDictionary(kPref);

- EXPECT_CALL(observer_, Observe(_, _, _)).Times(0);

+ EXPECT_CALL(observer_, OnPreferenceChanged(_, _)).Times(0);

{

DictionaryPrefUpdate update(&prefs_, kPref);

}