Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1309)

Unified Diff: chrome/browser/extensions/extension_service.cc

Issue 11345008: Remove content::NotificationObserver dependency from most Prefs code. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Merge to head for commit Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/extensions/extension_service.h ('k') | chrome/browser/extensions/external_policy_loader.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/extension_service.cc
diff --git a/chrome/browser/extensions/extension_service.cc b/chrome/browser/extensions/extension_service.cc
index eb41d529dee28be3cbc8cb0e2ab7bfe6d95dc6c1..ffb8152b0fe2d9f56e6db906afb8430df754e9ca 100644
--- a/chrome/browser/extensions/extension_service.cc
+++ b/chrome/browser/extensions/extension_service.cc
@@ -2582,16 +2582,6 @@ void ExtensionService::Observe(int type,
process->GetID()));
break;
}
- case chrome::NOTIFICATION_PREF_CHANGED: {
- const std::string& pref_name =
- *content::Details<std::string>(details).ptr();
- DCHECK(pref_name == prefs::kExtensionInstallAllowList ||
- pref_name == prefs::kExtensionInstallDenyList)
- << "Unexpected preference name " << pref_name;
- IdentifyAlertableExtensions();
- CheckManagementPolicy();
- break;
- }
case chrome::NOTIFICATION_IMPORT_FINISHED: {
InitAfterImport();
break;
@@ -2602,6 +2592,15 @@ void ExtensionService::Observe(int type,
}
}
+void ExtensionService::OnPreferenceChanged(PrefServiceBase* service,
+ const std::string& pref_name) {
+ DCHECK(pref_name == prefs::kExtensionInstallAllowList ||
+ pref_name == prefs::kExtensionInstallDenyList)
+ << "Unexpected preference name " << pref_name;
+ IdentifyAlertableExtensions();
+ CheckManagementPolicy();
+}
+
bool ExtensionService::HasApps() const {
return !GetAppIds().empty();
}
« no previous file with comments | « chrome/browser/extensions/extension_service.h ('k') | chrome/browser/extensions/external_policy_loader.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698