Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Side by Side Diff: chrome/browser/ui/gtk/bookmarks/bookmark_bar_gtk.h

Issue 11345008: Remove content::NotificationObserver dependency from most Prefs code. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Merge to head for commit Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_UI_GTK_BOOKMARKS_BOOKMARK_BAR_GTK_H_ 5 #ifndef CHROME_BROWSER_UI_GTK_BOOKMARKS_BOOKMARK_BAR_GTK_H_
6 #define CHROME_BROWSER_UI_GTK_BOOKMARKS_BOOKMARK_BAR_GTK_H_ 6 #define CHROME_BROWSER_UI_GTK_BOOKMARKS_BOOKMARK_BAR_GTK_H_
7 7
8 #include <gtk/gtk.h> 8 #include <gtk/gtk.h>
9 9
10 #include <vector> 10 #include <vector>
11 11
12 #include "base/compiler_specific.h" 12 #include "base/compiler_specific.h"
13 #include "base/gtest_prod_util.h" 13 #include "base/gtest_prod_util.h"
14 #include "base/memory/scoped_ptr.h" 14 #include "base/memory/scoped_ptr.h"
15 #include "base/memory/weak_ptr.h" 15 #include "base/memory/weak_ptr.h"
16 #include "base/prefs/public/pref_observer.h"
16 #include "chrome/browser/api/prefs/pref_member.h" 17 #include "chrome/browser/api/prefs/pref_member.h"
17 #include "chrome/browser/bookmarks/bookmark_model_observer.h" 18 #include "chrome/browser/bookmarks/bookmark_model_observer.h"
18 #include "chrome/browser/ui/bookmarks/bookmark_bar.h" 19 #include "chrome/browser/ui/bookmarks/bookmark_bar.h"
19 #include "chrome/browser/ui/bookmarks/bookmark_bar_instructions_delegate.h" 20 #include "chrome/browser/ui/bookmarks/bookmark_bar_instructions_delegate.h"
20 #include "chrome/browser/ui/bookmarks/bookmark_context_menu_controller.h" 21 #include "chrome/browser/ui/bookmarks/bookmark_context_menu_controller.h"
21 #include "chrome/browser/ui/gtk/menu_bar_helper.h" 22 #include "chrome/browser/ui/gtk/menu_bar_helper.h"
22 #include "chrome/browser/ui/gtk/view_id_util.h" 23 #include "chrome/browser/ui/gtk/view_id_util.h"
23 #include "content/public/browser/notification_observer.h" 24 #include "content/public/browser/notification_observer.h"
24 #include "content/public/browser/notification_registrar.h" 25 #include "content/public/browser/notification_registrar.h"
25 #include "ui/base/animation/animation.h" 26 #include "ui/base/animation/animation.h"
(...skipping 13 matching lines...) Expand all
39 class TabstripOriginProvider; 40 class TabstripOriginProvider;
40 41
41 namespace content { 42 namespace content {
42 class PageNavigator; 43 class PageNavigator;
43 } 44 }
44 45
45 class BookmarkBarGtk : public ui::AnimationDelegate, 46 class BookmarkBarGtk : public ui::AnimationDelegate,
46 public BookmarkModelObserver, 47 public BookmarkModelObserver,
47 public MenuBarHelper::Delegate, 48 public MenuBarHelper::Delegate,
48 public content::NotificationObserver, 49 public content::NotificationObserver,
50 public PrefObserver,
49 public chrome::BookmarkBarInstructionsDelegate, 51 public chrome::BookmarkBarInstructionsDelegate,
50 public BookmarkContextMenuControllerDelegate { 52 public BookmarkContextMenuControllerDelegate {
51 public: 53 public:
52 BookmarkBarGtk(BrowserWindowGtk* window, 54 BookmarkBarGtk(BrowserWindowGtk* window,
53 Browser* browser, 55 Browser* browser,
54 TabstripOriginProvider* tabstrip_origin_provider); 56 TabstripOriginProvider* tabstrip_origin_provider);
55 virtual ~BookmarkBarGtk(); 57 virtual ~BookmarkBarGtk();
56 58
57 // Returns the current browser. 59 // Returns the current browser.
58 Browser* browser() const { return browser_; } 60 Browser* browser() const { return browser_; }
(...skipping 170 matching lines...) Expand 10 before | Expand all | Expand 10 after
229 virtual void BookmarkNodeFaviconChanged(BookmarkModel* model, 231 virtual void BookmarkNodeFaviconChanged(BookmarkModel* model,
230 const BookmarkNode* node) OVERRIDE; 232 const BookmarkNode* node) OVERRIDE;
231 virtual void BookmarkNodeChildrenReordered(BookmarkModel* model, 233 virtual void BookmarkNodeChildrenReordered(BookmarkModel* model,
232 const BookmarkNode* node) OVERRIDE; 234 const BookmarkNode* node) OVERRIDE;
233 235
234 // Overridden from content::NotificationObserver: 236 // Overridden from content::NotificationObserver:
235 virtual void Observe(int type, 237 virtual void Observe(int type,
236 const content::NotificationSource& source, 238 const content::NotificationSource& source,
237 const content::NotificationDetails& details) OVERRIDE; 239 const content::NotificationDetails& details) OVERRIDE;
238 240
241 // Overridden from PrefObserver:
242 virtual void OnPreferenceChanged(PrefServiceBase* service,
243 const std::string& pref_name) OVERRIDE;
244
245
239 GtkWidget* CreateBookmarkButton(const BookmarkNode* node); 246 GtkWidget* CreateBookmarkButton(const BookmarkNode* node);
240 GtkToolItem* CreateBookmarkToolItem(const BookmarkNode* node); 247 GtkToolItem* CreateBookmarkToolItem(const BookmarkNode* node);
241 248
242 void ConnectFolderButtonEvents(GtkWidget* widget, bool is_tool_item); 249 void ConnectFolderButtonEvents(GtkWidget* widget, bool is_tool_item);
243 250
244 // Finds the BookmarkNode from the model associated with |button|. 251 // Finds the BookmarkNode from the model associated with |button|.
245 const BookmarkNode* GetNodeForToolButton(GtkWidget* button); 252 const BookmarkNode* GetNodeForToolButton(GtkWidget* button);
246 253
247 // Creates and displays a popup menu for BookmarkNode |node|. 254 // Creates and displays a popup menu for BookmarkNode |node|.
248 void PopupMenuForNode(GtkWidget* sender, const BookmarkNode* node, 255 void PopupMenuForNode(GtkWidget* sender, const BookmarkNode* node,
(...skipping 154 matching lines...) Expand 10 before | Expand all | Expand 10 after
403 410
404 BookmarkBar::State bookmark_bar_state_; 411 BookmarkBar::State bookmark_bar_state_;
405 412
406 // Maximum height of the bookmark bar. 413 // Maximum height of the bookmark bar.
407 int max_height_; 414 int max_height_;
408 415
409 DISALLOW_COPY_AND_ASSIGN(BookmarkBarGtk); 416 DISALLOW_COPY_AND_ASSIGN(BookmarkBarGtk);
410 }; 417 };
411 418
412 #endif // CHROME_BROWSER_UI_GTK_BOOKMARKS_BOOKMARK_BAR_GTK_H_ 419 #endif // CHROME_BROWSER_UI_GTK_BOOKMARKS_BOOKMARK_BAR_GTK_H_
OLDNEW
« no previous file with comments | « chrome/browser/ui/gesture_prefs_observer_factory_aura.cc ('k') | chrome/browser/ui/gtk/bookmarks/bookmark_bar_gtk.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698