Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(599)

Side by Side Diff: chrome/browser/chromeos/preferences.cc

Issue 11345008: Remove content::NotificationObserver dependency from most Prefs code. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Merge to head for commit Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/chromeos/preferences.h" 5 #include "chrome/browser/chromeos/preferences.h"
6 6
7 #include "base/chromeos/chromeos_version.h" 7 #include "base/chromeos/chromeos_version.h"
8 #include "base/command_line.h" 8 #include "base/command_line.h"
9 #include "base/i18n/time_formatting.h" 9 #include "base/i18n/time_formatting.h"
10 #include "base/metrics/histogram.h" 10 #include "base/metrics/histogram.h"
(...skipping 12 matching lines...) Expand all
23 #include "chrome/browser/chromeos/system/drm_settings.h" 23 #include "chrome/browser/chromeos/system/drm_settings.h"
24 #include "chrome/browser/chromeos/system/input_device_settings.h" 24 #include "chrome/browser/chromeos/system/input_device_settings.h"
25 #include "chrome/browser/chromeos/system/power_manager_settings.h" 25 #include "chrome/browser/chromeos/system/power_manager_settings.h"
26 #include "chrome/browser/chromeos/system/statistics_provider.h" 26 #include "chrome/browser/chromeos/system/statistics_provider.h"
27 #include "chrome/browser/download/download_util.h" 27 #include "chrome/browser/download/download_util.h"
28 #include "chrome/browser/prefs/pref_service.h" 28 #include "chrome/browser/prefs/pref_service.h"
29 #include "chrome/browser/prefs/scoped_user_pref_update.h" 29 #include "chrome/browser/prefs/scoped_user_pref_update.h"
30 #include "chrome/common/chrome_notification_types.h" 30 #include "chrome/common/chrome_notification_types.h"
31 #include "chrome/common/chrome_switches.h" 31 #include "chrome/common/chrome_switches.h"
32 #include "chrome/common/pref_names.h" 32 #include "chrome/common/pref_names.h"
33 #include "content/public/browser/notification_details.h"
34 #include "content/public/browser/notification_source.h"
35 #include "googleurl/src/gurl.h" 33 #include "googleurl/src/gurl.h"
36 #include "ui/base/events/event_constants.h" 34 #include "ui/base/events/event_constants.h"
37 #include "unicode/timezone.h" 35 #include "unicode/timezone.h"
38 36
39 namespace chromeos { 37 namespace chromeos {
40 38
41 static const char kFallbackInputMethodLocale[] = "en-US"; 39 static const char kFallbackInputMethodLocale[] = "en-US";
42 40
43 Preferences::Preferences() 41 Preferences::Preferences()
44 : prefs_(NULL), 42 : prefs_(NULL),
(...skipping 341 matching lines...) Expand 10 before | Expand all | Expand 10 after
386 } 384 }
387 385
388 void Preferences::InitUserPrefsForTesting(PrefService* prefs) { 386 void Preferences::InitUserPrefsForTesting(PrefService* prefs) {
389 InitUserPrefs(prefs); 387 InitUserPrefs(prefs);
390 } 388 }
391 389
392 void Preferences::SetInputMethodListForTesting() { 390 void Preferences::SetInputMethodListForTesting() {
393 SetInputMethodList(); 391 SetInputMethodList();
394 } 392 }
395 393
396 void Preferences::Observe(int type, 394 void Preferences::OnPreferenceChanged(PrefServiceBase* service,
397 const content::NotificationSource& source, 395 const std::string& pref_name) {
398 const content::NotificationDetails& details) { 396 NotifyPrefChanged(&pref_name);
399 if (type == chrome::NOTIFICATION_PREF_CHANGED)
400 NotifyPrefChanged(content::Details<std::string>(details).ptr());
401 } 397 }
402 398
403 void Preferences::NotifyPrefChanged(const std::string* pref_name) { 399 void Preferences::NotifyPrefChanged(const std::string* pref_name) {
404 if (!pref_name || *pref_name == prefs::kTapToClickEnabled) { 400 if (!pref_name || *pref_name == prefs::kTapToClickEnabled) {
405 const bool enabled = tap_to_click_enabled_.GetValue(); 401 const bool enabled = tap_to_click_enabled_.GetValue();
406 system::touchpad_settings::SetTapToClick(enabled); 402 system::touchpad_settings::SetTapToClick(enabled);
407 if (pref_name) 403 if (pref_name)
408 UMA_HISTOGRAM_BOOLEAN("Touchpad.TapToClick.Changed", enabled); 404 UMA_HISTOGRAM_BOOLEAN("Touchpad.TapToClick.Changed", enabled);
409 else 405 else
410 UMA_HISTOGRAM_BOOLEAN("Touchpad.TapToClick.Started", enabled); 406 UMA_HISTOGRAM_BOOLEAN("Touchpad.TapToClick.Started", enabled);
(...skipping 348 matching lines...) Expand 10 before | Expand all | Expand 10 after
759 755
760 input_method::AutoRepeatRate rate; 756 input_method::AutoRepeatRate rate;
761 rate.initial_delay_in_ms = xkb_auto_repeat_delay_pref_.GetValue(); 757 rate.initial_delay_in_ms = xkb_auto_repeat_delay_pref_.GetValue();
762 rate.repeat_interval_in_ms = xkb_auto_repeat_interval_pref_.GetValue(); 758 rate.repeat_interval_in_ms = xkb_auto_repeat_interval_pref_.GetValue();
763 DCHECK(rate.initial_delay_in_ms > 0); 759 DCHECK(rate.initial_delay_in_ms > 0);
764 DCHECK(rate.repeat_interval_in_ms > 0); 760 DCHECK(rate.repeat_interval_in_ms > 0);
765 input_method::XKeyboard::SetAutoRepeatRate(rate); 761 input_method::XKeyboard::SetAutoRepeatRate(rate);
766 } 762 }
767 763
768 } // namespace chromeos 764 } // namespace chromeos
OLDNEW
« no previous file with comments | « chrome/browser/chromeos/preferences.h ('k') | chrome/browser/chromeos/proxy_config_service_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698