Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(174)

Unified Diff: src/objects-inl.h

Issue 11344012: Make so that array length property access uses a new IC that tracks the array map. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/objects.h ('k') | src/stub-cache.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/objects-inl.h
diff --git a/src/objects-inl.h b/src/objects-inl.h
index 4e7d8f8c08702943ef60fb3692b5ceb56482ec5d..14db249d6d82c246c59fec6936d98bb8167ce05f 100644
--- a/src/objects-inl.h
+++ b/src/objects-inl.h
@@ -3495,12 +3495,13 @@ Code::Flags Code::ComputeFlags(Kind kind,
StubType type,
int argc,
InlineCacheHolderFlag holder) {
- // Extra IC state is only allowed for call IC stubs or for store IC
- // stubs.
+ // Extra IC state is only allowed for call IC stubs, store IC stubs or
+ // load ICs with type CALLBACKS.
ASSERT(extra_ic_state == kNoExtraICState ||
kind == CALL_IC ||
kind == STORE_IC ||
- kind == KEYED_STORE_IC);
+ kind == KEYED_STORE_IC ||
+ (kind == LOAD_IC && type == CALLBACKS));
// Compute the bit mask.
int bits = KindField::encode(kind)
| ICStateField::encode(ic_state)
« no previous file with comments | « src/objects.h ('k') | src/stub-cache.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698