Issue 11344012: Make so that array length property access uses a new IC that tracks the array map.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11344012: Make so that array length property access uses a new IC that tracks the array map. (Closed)

Created:
8 years, 1 month ago by Massi

Modified:
8 years, 1 month ago

Reviewers:
Jakob Kummerow

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Make so that array length property access uses a new IC that tracks the array map. (Closed because we picked a different aproach: https://chromiumcodereview.appspot.com/11299004) BUG=

Patch Set 1 #

Created: 8 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+289 lines, -33 lines)			Patch
M	src/arm/stub-cache-arm.cc	View	1 chunk	+50 lines, -0 lines	0 comments	Download
M	src/ast.cc	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	src/hydrogen.cc	View	1 chunk	+18 lines, -3 lines	0 comments	Download
M	src/ia32/stub-cache-ia32.cc	View	1 chunk	+50 lines, -0 lines	0 comments	Download
M	src/ic.cc	View	2 chunks	+10 lines, -23 lines	0 comments	Download
M	src/objects.h	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	src/objects-inl.h	View	1 chunk	+4 lines, -3 lines	0 comments	Download
M	src/stub-cache.h	View	3 chunks	+14 lines, -1 line	0 comments	Download
M	src/stub-cache.cc	View	2 chunks	+27 lines, -3 lines	0 comments	Download
M	src/type-info.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/type-info.cc	View	1 chunk	+25 lines, -0 lines	0 comments	Download
M	src/x64/stub-cache-x64.cc	View	1 chunk	+50 lines, -0 lines	0 comments	Download
M	test/mjsunit/array-length.js	View	2 chunks	+31 lines, -0 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

Massi

8 years, 1 month ago (2012-10-29 14:47:53 UTC) #1

This patch looks pointless but its real purpose is to make so that in hydrogen
JSArrayLength in branches and JSArayLength used in bound checks look exactly the
same and can get the same GVN number.
This will enable proper array bounds check elimination in a following CL.

Expand Messages | Collapse Messages