Added test for findbugs plugin.

Added test for findbugs plugin.

- The java files had the issue that findbugd plugin need to find out, they
  compiled with the same configuration as chrome for android's.

- The run_findbugs_plugin_tests.py runs the findbugs against the above Java
  classes, and expects to find the same issues as those in expected_result.txt.

BUG=143971, 157970
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=165442

[michaelbai, 2012-10-30 22:28:53]

The gyp file was carelessly checked in
http://src.chromium.org/viewvc/chrome?view=rev&revision=164990

Sorry about that.

I will fix any issue of findbugs_plugin.gyp file.

[Yaron, 2012-10-31 00:40:27]

http://codereview.chromium.org/11343057/diff/1/tools/android/findbugs_plugin/...
File tools/android/findbugs_plugin/test/run_findbugs_plugin_tests.py (right):

http://codereview.chromium.org/11343057/diff/1/tools/android/findbugs_plugin/...
tools/android/findbugs_plugin/test/run_findbugs_plugin_tests.py:1:
#!/usr/bin/env python
Where were you thinking to run this script? Currently it's not invoked.

http://codereview.chromium.org/11343057/diff/1/tools/android/findbugs_plugin/...
tools/android/findbugs_plugin/test/run_findbugs_plugin_tests.py:10: # issue with
those in expected_result.txt, If the difference is fund out,
Change the "," to "." and remove the rest of the sentence.

[michaelbai, 2012-10-31 04:36:24]

PTAL

http://codereview.chromium.org/11343057/diff/1/tools/android/findbugs_plugin/...
File tools/android/findbugs_plugin/test/run_findbugs_plugin_tests.py (right):

http://codereview.chromium.org/11343057/diff/1/tools/android/findbugs_plugin/...
tools/android/findbugs_plugin/test/run_findbugs_plugin_tests.py:1:
#!/usr/bin/env python
I am plan to run it in a bot, might just after findbugs_diff.py

On 2012/10/31 00:40:28, Yaron wrote:
> Where were you thinking to run this script? Currently it's not invoked.

http://codereview.chromium.org/11343057/diff/1/tools/android/findbugs_plugin/...
tools/android/findbugs_plugin/test/run_findbugs_plugin_tests.py:10: # issue with
those in expected_result.txt, If the difference is fund out,
On 2012/10/31 00:40:28, Yaron wrote:
> Change the "," to "." and remove the rest of the sentence.

Done.

[Yaron, 2012-10-31 16:43:35]

lgtm

[commit-bot: I haz the power, 2012-11-01 16:23:43]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/michaelbai@chromium.org/11343057/5001

[commit-bot: I haz the power, 2012-11-01 18:22:01]

Commit queue rejected this change because the description was changed
between the time the change entered the commit queue and the time it
was ready to commit. You can safely check the commit box again.

[commit-bot: I haz the power, 2012-11-01 18:24:00]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/michaelbai@chromium.org/11343057/5001

[commit-bot: I haz the power, 2012-11-01 18:24:29]

Change committed as 165442