Issue 11343050: [Chromoting] Make the AuthCodeGetter component of the Windows host configurer

Issue 11343050: [Chromoting] Make the AuthCodeGetter component of the Windows host configurer (Closed)

Created:
8 years, 1 month ago by simonmorris

Modified:
8 years, 1 month ago

Reviewers:
alexeypa (please no reviews)

CC:
chromium-reviews, jamiewalch+watch_chromium.org, dcaiafa+watch_chromium.org, simonmorris+watch_chromium.org, hclam+watch_chromium.org, wez+watch_chromium.org, amit, sanjeevr, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, rmsousa+watch_chromium.org, alexeypa+watch_chromium.org, sergeyu+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

[Chromoting] Make the AuthCodeGetter component of the Windows host configurer use ScopedComPtr correctly. BUG=158611 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=165061

Patch Set 1 #

Total comments: 6

Patch Set 2 : Use a simpler idiom. #

Created: 8 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -8 lines)			Patch
	M	remoting/host/setup/win/auth_code_getter.h	View		1 chunk	+0 lines, -2 lines	0 comments	Download
	M	remoting/host/setup/win/auth_code_getter.cc	View	1	5 chunks	+4 lines, -6 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

alexeypa (please no reviews)

lgtm once my comments are addressed. http://codereview.chromium.org/11343050/diff/1/remoting/host/setup/win/auth_code_getter.cc File remoting/host/setup/win/auth_code_getter.cc (right): http://codereview.chromium.org/11343050/diff/1/remoting/host/setup/win/auth_code_getter.cc#newcode30 remoting/host/setup/win/auth_code_getter.cc:30: if (!browser_.IsSameObject(NULL)) { ...

8 years, 1 month ago (2012-10-30 21:17:35 UTC) #2

simonmorris

fyi http://codereview.chromium.org/11343050/diff/1/remoting/host/setup/win/auth_code_getter.cc File remoting/host/setup/win/auth_code_getter.cc (right): http://codereview.chromium.org/11343050/diff/1/remoting/host/setup/win/auth_code_getter.cc#newcode30 remoting/host/setup/win/auth_code_getter.cc:30: if (!browser_.IsSameObject(NULL)) { On 2012/10/30 21:17:35, alexeypa wrote: ...

8 years, 1 month ago (2012-10-30 21:24:37 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/simonmorris@chromium.org/11343050/4001

8 years, 1 month ago (2012-10-30 21:25:07 UTC) #4

Change committed as 165061

Expand Messages | Collapse Messages