third_party/libxml/src/parser.c - Issue 11343029: Add a check to prevent len from going negative in xmlParseAttValueComplex.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/libxml/src/parser.c

Issue 11343029: Add a check to prevent len from going negative in xmlParseAttValueComplex. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 8 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/libxml/src/parser.c

diff --git a/third_party/libxml/src/parser.c b/third_party/libxml/src/parser.c

index c181071a531c547ccb0fea7247e859eab84e6c2f..0b803550b314655082d9ce582cd947419696b1e2 100644

--- a/third_party/libxml/src/parser.c

+++ b/third_party/libxml/src/parser.c

@@ -3800,7 +3800,7 @@ xmlParseAttValueComplex(xmlParserCtxtPtr ctxt, int *attlen, int normalize) {

c = CUR_CHAR(l);

}

if ((in_space) && (normalize)) {

- while (buf[len - 1] == 0x20) len--;

+ while ((len > 0) && (buf[len - 1] == 0x20)) len--;

}

buf[len] = 0;

if (RAW == '<') {

« no previous file with comments | « third_party/libxml/README.chromium ('k') | no next file » | no next file with comments »