Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(770)

Issue 11343022: dbus: Everybody can include from src/base/. (Closed)

Created:
8 years, 1 month ago by tfarina
Modified:
8 years, 1 month ago
Reviewers:
satorux1
CC:
chromium-reviews
Visibility:
Public.

Description

dbus: Everybody can include from src/base/. R=satorux@chromium.org NOTRY=True Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=165178

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M dbus/DEPS View 1 chunk +1 line, -2 lines 2 comments Download

Messages

Total messages: 6 (0 generated)
tfarina
Hi Satoru-san, could you review this to me?
8 years, 1 month ago (2012-10-29 19:15:35 UTC) #1
satorux1
http://codereview.chromium.org/11343022/diff/1/dbus/DEPS File dbus/DEPS (right): http://codereview.chromium.org/11343022/diff/1/dbus/DEPS#newcode3 dbus/DEPS:3: ] What's the change here? did you add a ...
8 years, 1 month ago (2012-10-29 21:48:53 UTC) #2
tfarina
http://codereview.chromium.org/11343022/diff/1/dbus/DEPS File dbus/DEPS (right): http://codereview.chromium.org/11343022/diff/1/dbus/DEPS#newcode3 dbus/DEPS:3: ] On 2012/10/29 21:48:53, satorux1 wrote: > What's the ...
8 years, 1 month ago (2012-10-29 21:50:50 UTC) #3
satorux1
LGTM. Please ensure that the last line ends with LF.
8 years, 1 month ago (2012-10-29 22:01:54 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/11343022/1
8 years, 1 month ago (2012-10-31 16:22:12 UTC) #5
commit-bot: I haz the power
8 years, 1 month ago (2012-10-31 16:38:50 UTC) #6
Change committed as 165178

Powered by Google App Engine
This is Rietveld 408576698