Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(143)

Issue 11340023: Only try keyring password once for code.google.com (Closed)

Created:
8 years, 1 month ago by cjhopman
Modified:
8 years, 1 month ago
Reviewers:
cmp
CC:
chromium-reviews, Dirk Pranke, cmp+cc_chromium.org, M-A Ruel
Visibility:
Public.

Description

Only try keyring password once for code.google.com If the keyring password doesn't work on the first try, it probably won't work on the second or third. The KeyringCreds object already supports this, we just were recreating the object at each step. Also, if after three tries authentication to code.google.com still fails, then the script should continue and just use un-authenticated access to code.google.com. BUG=158388 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=165446

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -12 lines) Patch
M my_activity.py View 3 chunks +19 lines, -12 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
cjhopman
8 years, 1 month ago (2012-10-29 22:45:55 UTC) #1
cjhopman
cmp: for depot_tools owners
8 years, 1 month ago (2012-11-01 18:43:19 UTC) #2
cmp
lgtm
8 years, 1 month ago (2012-11-01 18:48:32 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cjhopman@chromium.org/11340023/1
8 years, 1 month ago (2012-11-01 18:50:36 UTC) #4
commit-bot: I haz the power
8 years, 1 month ago (2012-11-01 18:53:14 UTC) #5
Change committed as 165446

Powered by Google App Engine
This is Rietveld 408576698