Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(2)

Issue 11340010: Correctly visit all external strings. (Closed)

Created:
5 years, 7 months ago by Yang
Modified:
5 years, 7 months ago
Reviewers:
erikcorry, Erik Corry
CC:
v8-dev, yurys
Visibility:
Public.

Description

Correctly visit all external strings. BUG= Committed: https://code.google.com/p/v8/source/detail?r=12841

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+75 lines, -32 lines) Patch
M include/v8.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M src/heap.cc View 1 2 chunks +33 lines, -5 lines 0 comments Download
M test/cctest/test-api.cc View 1 3 chunks +40 lines, -25 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Yang
Please take a look. This solves the issue in https://chromiumcodereview.appspot.com/11315004/ that we have discussed about. ...
5 years, 7 months ago (2012-10-29 16:38:07 UTC) #1
loislo
sounds good to me
5 years, 7 months ago (2012-10-31 15:19:50 UTC) #2
loislo
On 2012/10/31 15:19:50, loislo wrote: > sounds good to me ping
5 years, 7 months ago (2012-11-02 11:51:40 UTC) #3
erikcorry
LGTM https://chromiumcodereview.appspot.com/11340010/diff/1/src/heap.cc File src/heap.cc (right): https://chromiumcodereview.appspot.com/11340010/diff/1/src/heap.cc#newcode1601 src/heap.cc:1601: } external_string_table_visitor(visitor); Please add a blank line here ...
5 years, 7 months ago (2012-11-02 12:02:58 UTC) #4
erikcorry
5 years, 7 months ago (2012-11-02 12:04:36 UTC) #5
One more thing:  the comment in include/v8.h mentions that this may be slow,
which it probably isn't.  On the other hand it should probably mention that we
don't do a GC as part of this call, so you may get callbacks for resources that
are actually dead.

Powered by Google App Engine
This is Rietveld 408576698