Correctly visit all external strings.

Correctly visit all external strings.

BUG=

Committed: https://code.google.com/p/v8/source/detail?r=12841

[Yang, 2012-10-29 16:38:07]

Please take a look.

This solves the issue in https://chromiumcodereview.appspot.com/11315004/
that we have discussed about. It implements option 3 in my reply: we visit all
strings in the external string table that are not symbols, and then visit the
all external strings in the symbol table (the rest).

[loislo, 2012-10-31 15:19:50]

sounds good to me

[loislo, 2012-11-02 11:51:40]

On 2012/10/31 15:19:50, loislo wrote:
> sounds good to me

ping

[erikcorry, 2012-11-02 12:02:58]

LGTM

https://chromiumcodereview.appspot.com/11340010/diff/1/src/heap.cc
File src/heap.cc (right):

https://chromiumcodereview.appspot.com/11340010/diff/1/src/heap.cc#newcode1601
src/heap.cc:1601: } external_string_table_visitor(visitor);
Please add a blank line here between the class definition and the invocation of
Iterate, so it stands out more.  Or you could move it down to the other
invocation

https://chromiumcodereview.appspot.com/11340010/diff/1/src/heap.cc#newcode1619
src/heap.cc:1619: } symbol_table_visitor(visitor);
Blank line here please.

[erikcorry, 2012-11-02 12:04:36]

One more thing:  the comment in include/v8.h mentions that this may be slow,
which it probably isn't.  On the other hand it should probably mention that we
don't do a GC as part of this call, so you may get callbacks for resources that
are actually dead.