Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(151)

Unified Diff: tools/safely-roll-webkit.py

Issue 11339053: Add link to WebKit revision log for WebKit rolls. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/safely-roll-webkit.py
diff --git a/tools/safely-roll-webkit.py b/tools/safely-roll-webkit.py
index 5f38deb460a787443b18617ae19513813a26503e..c9e580fc3c0f29b5173fbbd3aa5838d07c6aa250 100755
--- a/tools/safely-roll-webkit.py
+++ b/tools/safely-roll-webkit.py
@@ -82,11 +82,17 @@ def main():
subprocess2.check_output(
['git', 'checkout', '-b', 'webkit_roll', options.upstream])
try:
- old_rev = process_deps(os.path.join(root_dir, 'DEPS'), new_rev)
+ old_rev = int(process_deps(os.path.join(root_dir, 'DEPS'), new_rev))
review_field = 'TBR' if options.commit else 'R'
- commit_msg = 'Webkit roll %s:%s\n\n%s=%s\n' % (old_rev, new_rev,
- review_field,
- options.reviewers)
+ commit_msg = ('Webkit roll %s:%s\n'
+ '\n'
+ 'http://trac.webkit.org/log/?'
+ 'rev=%s&stop_rev=%s&verbose=on\n'
+ '\n'
+ '%s=%s\n' % (old_rev, new_rev,
+ new_rev, old_rev+1,
+ review_field,
+ options.reviewers))
subprocess2.check_output(['git', 'commit', '-m', commit_msg, 'DEPS'])
subprocess2.check_call(['git', 'diff', options.upstream])
upload_cmd = ['git', 'cl', 'upload']
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698