Issue 11339036: Temporarily disable adding already attached removable devices to system monitor.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11339036: Temporarily disable adding already attached removable devices to system monitor. (Closed)

Created:
8 years, 1 month ago by vandebo (ex-Chrome)

Modified:
8 years, 1 month ago

Reviewers:
Lei Zhang

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Temporarily disable adding already attached removable devices to system monitor. BUG=155910 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=164873

Patch Set 2 : typo #

Created: 8 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+18 lines, -7 lines)			Patch
	M	chrome/browser/system_monitor/removable_device_notifications_window_win_unittest.cc	View	1	5 chunks	+13 lines, -5 lines	0 comments	Download
	M	chrome/browser/system_monitor/volume_mount_watcher_win.cc	View		1 chunk	+5 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Lei Zhang

lgtm https://codereview.chromium.org/11339036/diff/1/chrome/browser/system_monitor/removable_device_notifications_window_win_unittest.cc File chrome/browser/system_monitor/removable_device_notifications_window_win_unittest.cc (right): https://codereview.chromium.org/11339036/diff/1/chrome/browser/system_monitor/removable_device_notifications_window_win_unittest.cc#newcode344 chrome/browser/system_monitor/removable_device_notifications_window_win_unittest.cc:344: TEST_F(RemovableDeviceNotificationsWindowWinTest, DISALBED_DeviceInfoForPath) { You fixed one typo and ...

8 years, 1 month ago (2012-10-30 05:21:31 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vandebo@chromium.org/11339036/4001

8 years, 1 month ago (2012-10-30 05:25:32 UTC) #3

Change committed as 164873

Expand Messages | Collapse Messages

Issue 11339036: Temporarily disable adding already attached removable devices to system monitor. (Closed)

Description

Patch Set 1 #

Patch Set 2 : typo #

Messages