Add structural support for building chrome_browser_ui.gypi on iOS

Add structural support for building chrome_browser_ui.gypi on iOS

This is not yet used, but helps lay the groundwork for building chrome/
targets for iOS.

This uses exclude-all-and-include since Chrome for iOS uses only a very
small portion of chrome/browser/ui/, so the include list will be much more
manageable and maintainable than an exclude list.

BUG=156699
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=164908

[stuartmorgan, 2012-10-29 10:01:08]

I tried doing specific excludes, and the list was up to 60+ exclusions; with the
inclusions it'll end up in the 10-20 range.

[Nico, 2012-10-29 17:05:51]

lgtm, but this makes it difficult for non-ios people to judge which list to add
stuff to. Do you have a good idea how to help with that? Worst case, add a
comment like "When in doubt, add the dependency in the os!=ios block below"?

https://codereview.chromium.org/11339010/diff/2002/chrome/chrome_browser_ui.gypi
File chrome/chrome_browser_ui.gypi (right):

https://codereview.chromium.org/11339010/diff/2002/chrome/chrome_browser_ui.g...
chrome/chrome_browser_ui.gypi:13: # we must omit the dependency from
browser_extensions to browser.
While you're here: I think this should be browser_ui, not browser_extensions.

You'll have to do the same changes to chrome_browser.gypi, do you want to do
this at the same time? (I'm happy either way.)

[stuartmorgan, 2012-10-30 05:58:26]

On 2012/10/29 17:05:51, Nico wrote:
> lgtm, but this makes it difficult for non-ios people to judge which list to
add
> stuff to. Do you have a good idea how to help with that? Worst case, add a
> comment like "When in doubt, add the dependency in the os!=ios block below"?

Yeah, this is a general problem that we don't have a great solution for. I'll
add the comment since it's better than nothing.

In the short term I expect people to break us occasionally, and then us to fix
it. Once I actually get a build going, the try bots will do a pretty good job of
enforcing it.

> You'll have to do the same changes to chrome_browser.gypi, do you want to do
> this at the same time? (I'm happy either way.)

No, but it'll come soon. It'll take me another day or two to get chrome_browser
adapted (these aren't existing changes that are being upstreamed; maintaining
significant diffs in a huge gyp file in the long term is basically impossible,
so we had totally separate files that I'm now merging into the existing gyp
structure incrementally and then upstreaming as I go). Since these files have a
lot of churn, leaving the diffs uncommitted for days means a lot of drift.

[stuartmorgan, 2012-10-30 11:58:43]

https://codereview.chromium.org/11339010/diff/2002/chrome/chrome_browser_ui.gypi
File chrome/chrome_browser_ui.gypi (right):

https://codereview.chromium.org/11339010/diff/2002/chrome/chrome_browser_ui.g...
chrome/chrome_browser_ui.gypi:13: # we must omit the dependency from
browser_extensions to browser.
On 2012/10/29 17:05:51, Nico wrote:
> While you're here: I think this should be browser_ui, not browser_extensions.

Done.

[commit-bot: I haz the power, 2012-10-30 11:59:00]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/stuartmorgan@chromium.org/11339010/9001

[commit-bot: I haz the power, 2012-10-30 13:55:10]

Change committed as 164908