Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 11337030: The content_common target should depend on webkit's glue target. (Closed)

Created:
8 years, 1 month ago by Lei Zhang
Modified:
8 years, 1 month ago
Reviewers:
brettw
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Visibility:
Public.

Description

The content_common target should depend on webkit's glue target. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=165264

Patch Set 1 #

Patch Set 2 : fix ios #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M content/content_common.gypi View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Lei Zhang
When I do a clobber build of device_unittest, I get this linker error: third_party/gold/gold64: obj/content/libcontent_common.a(obj/content/public/common/content_common.pepper_plugin_info.o): ...
8 years, 1 month ago (2012-10-30 20:08:18 UTC) #1
brettw
lgtm
8 years, 1 month ago (2012-10-31 18:21:01 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/11337030/1
8 years, 1 month ago (2012-10-31 18:58:36 UTC) #3
Lei Zhang
Whoops, did not know iOS excludes a good part of webkit. Patch set 2 puts ...
8 years, 1 month ago (2012-10-31 19:07:04 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/11337030/13001
8 years, 1 month ago (2012-10-31 19:07:23 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/11337030/13001
8 years, 1 month ago (2012-10-31 21:50:08 UTC) #6
commit-bot: I haz the power
8 years, 1 month ago (2012-10-31 23:55:42 UTC) #7
Change committed as 165264

Powered by Google App Engine
This is Rietveld 408576698