Dummy dev_environment component app

Dummy dev_environment component app

We are moving the developer features from the extensions page into a V2 component app. This diff adds a dummy component app.

BUG=149036
TBR=sky@chromium.org


Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=169911

[Gaurav, 2012-10-30 20:53:58]

@estade chrome/browser/resources
@miket chrome/browser/extensions/

[miket_OOO, 2012-10-30 20:57:38]

On 2012/10/30 20:53:58, Gaurav wrote:
> @estade chrome/browser/resources
> @miket chrome/browser/extensions/

I'm getting chunk-match failures on some of the files. You might need to rebase
and re-upload.

[miket_OOO, 2012-10-30 20:57:46]

https://chromiumcodereview.appspot.com/11336036/diff/1/chrome/browser/resourc...
File chrome/browser/resources/dev_environment/background.js (right):

https://chromiumcodereview.appspot.com/11336036/diff/1/chrome/browser/resourc...
chrome/browser/resources/dev_environment/background.js:4: 'height': 900
A typical Chromebook is 768 pixels high. Will this look OK on such a device?

https://chromiumcodereview.appspot.com/11336036/diff/1/chrome/browser/resourc...
File chrome/browser/resources/dev_environment/manifest.json (right):

https://chromiumcodereview.appspot.com/11336036/diff/1/chrome/browser/resourc...
chrome/browser/resources/dev_environment/manifest.json:2: "key":
"MIGfMA0GCSqGSIb3DQEBAQUAA4GNADCBiQKBgQDdTTWp0WWTp4XU15/xCchl4x4ZvG31cx/VT567UDgMLUL/+8j+3w3C87UJemJ3I5x81XJv8lhK3eIxR05H59UFsW9C70/hZCQeOhi5Uutl1gAlG4xsJAX9EQjFmmKsN88wmfZvxNPlu0WoxtHxjXKogRfk+wujanMyXnmhHaDrvwIDAQAB",
I don't think there's a good reason to check in the key (at least, I can't think
of one).

https://chromiumcodereview.appspot.com/11336036/diff/1/chrome/browser/resourc...
chrome/browser/resources/dev_environment/manifest.json:3: "name": "Dev Tool",
This is a temp name -- can we think of a better one just in case we launch and
forget to change it?

https://chromiumcodereview.appspot.com/11336036/diff/1/chrome/browser/resourc...
chrome/browser/resources/dev_environment/manifest.json:4: "description": "Debug
chrome apps.",
Capitalize Chrome.

[miket_OOO, 2012-10-30 20:57:46]

https://chromiumcodereview.appspot.com/11336036/diff/1/chrome/browser/resourc...
File chrome/browser/resources/dev_environment/background.js (right):

https://chromiumcodereview.appspot.com/11336036/diff/1/chrome/browser/resourc...
chrome/browser/resources/dev_environment/background.js:4: 'height': 900
A typical Chromebook is 768 pixels high. Will this look OK on such a device?

https://chromiumcodereview.appspot.com/11336036/diff/1/chrome/browser/resourc...
File chrome/browser/resources/dev_environment/manifest.json (right):

https://chromiumcodereview.appspot.com/11336036/diff/1/chrome/browser/resourc...
chrome/browser/resources/dev_environment/manifest.json:2: "key":
"MIGfMA0GCSqGSIb3DQEBAQUAA4GNADCBiQKBgQDdTTWp0WWTp4XU15/xCchl4x4ZvG31cx/VT567UDgMLUL/+8j+3w3C87UJemJ3I5x81XJv8lhK3eIxR05H59UFsW9C70/hZCQeOhi5Uutl1gAlG4xsJAX9EQjFmmKsN88wmfZvxNPlu0WoxtHxjXKogRfk+wujanMyXnmhHaDrvwIDAQAB",
I don't think there's a good reason to check in the key (at least, I can't think
of one).

https://chromiumcodereview.appspot.com/11336036/diff/1/chrome/browser/resourc...
chrome/browser/resources/dev_environment/manifest.json:3: "name": "Dev Tool",
This is a temp name -- can we think of a better one just in case we launch and
forget to change it?

https://chromiumcodereview.appspot.com/11336036/diff/1/chrome/browser/resourc...
chrome/browser/resources/dev_environment/manifest.json:4: "description": "Debug
chrome apps.",
Capitalize Chrome.

[Evan Stade, 2012-10-30 21:16:42]

punting my review to dan

[Gaurav, 2012-10-30 21:17:58]

https://chromiumcodereview.appspot.com/11336036/diff/1/chrome/browser/resourc...
File chrome/browser/resources/dev_environment/background.js (right):

https://chromiumcodereview.appspot.com/11336036/diff/1/chrome/browser/resourc...
chrome/browser/resources/dev_environment/background.js:4: 'height': 900
Changed to 600 X 600
On 2012/10/30 20:57:46, miket wrote:
> A typical Chromebook is 768 pixels high. Will this look OK on such a device?

https://chromiumcodereview.appspot.com/11336036/diff/1/chrome/browser/resourc...
File chrome/browser/resources/dev_environment/manifest.json (right):

https://chromiumcodereview.appspot.com/11336036/diff/1/chrome/browser/resourc...
chrome/browser/resources/dev_environment/manifest.json:2: "key":
"MIGfMA0GCSqGSIb3DQEBAQUAA4GNADCBiQKBgQDdTTWp0WWTp4XU15/xCchl4x4ZvG31cx/VT567UDgMLUL/+8j+3w3C87UJemJ3I5x81XJv8lhK3eIxR05H59UFsW9C70/hZCQeOhi5Uutl1gAlG4xsJAX9EQjFmmKsN88wmfZvxNPlu0WoxtHxjXKogRfk+wujanMyXnmhHaDrvwIDAQAB",
The component extensions when parse manifest, needs this key
On 2012/10/30 20:57:46, miket wrote:
> I don't think there's a good reason to check in the key (at least, I can't
think
> of one).

https://chromiumcodereview.appspot.com/11336036/diff/1/chrome/browser/resourc...
chrome/browser/resources/dev_environment/manifest.json:3: "name": "Dev Tool",
On 2012/10/30 20:57:46, miket wrote:
> This is a temp name -- can we think of a better one just in case we launch and
> forget to change it?

Done.

https://chromiumcodereview.appspot.com/11336036/diff/1/chrome/browser/resourc...
chrome/browser/resources/dev_environment/manifest.json:4: "description": "Debug
chrome apps.",
On 2012/10/30 20:57:46, miket wrote:
> Capitalize Chrome.

Done.

[miket_OOO, 2012-10-31 17:11:29]

lgtm

[Dan Beam, 2012-10-31 20:50:11]

https://chromiumcodereview.appspot.com/11336036/diff/17001/chrome/browser/res...
File chrome/browser/resources/dev_environment/manifest.json (right):

https://chromiumcodereview.appspot.com/11336036/diff/17001/chrome/browser/res...
chrome/browser/resources/dev_environment/manifest.json:2: "key":
"MIGfMA0GCSqGSIb3DQEBAQUAA4GNADCBiQKBgQDdTTWp0WWTp4XU15/xCchl4x4ZvG31cx/VT567UDgMLUL/+8j+3w3C87UJemJ3I5x81XJv8lhK3eIxR05H59UFsW9C70/hZCQeOhi5Uutl1gAlG4xsJAX9EQjFmmKsN88wmfZvxNPlu0WoxtHxjXKogRfk+wujanMyXnmhHaDrvwIDAQAB",
nit: indent is off for "key"

https://chromiumcodereview.appspot.com/11336036/diff/17001/chrome/browser/res...
chrome/browser/resources/dev_environment/manifest.json:3: "name": "Chrome
Developer Tool",
I'm confused by this name, the directory is called "dev_environment" and I think
this will sound like the webkit inspector...

https://chromiumcodereview.appspot.com/11336036/diff/17001/chrome/browser/res...
chrome/browser/resources/dev_environment/manifest.json:13: "icons": { "16":
"images/dev-icon-16.png", "128": "images/dev-icon-128.png" }
nit: no spaces between { and "16" nor .png" and } if you keep oneline, otherwise
why is this not the same as the way "app" indents it's object literal?

[Gaurav, 2012-10-31 21:12:12]

https://chromiumcodereview.appspot.com/11336036/diff/17001/chrome/browser/res...
File chrome/browser/resources/dev_environment/manifest.json (right):

https://chromiumcodereview.appspot.com/11336036/diff/17001/chrome/browser/res...
chrome/browser/resources/dev_environment/manifest.json:2: "key":
"MIGfMA0GCSqGSIb3DQEBAQUAA4GNADCBiQKBgQDdTTWp0WWTp4XU15/xCchl4x4ZvG31cx/VT567UDgMLUL/+8j+3w3C87UJemJ3I5x81XJv8lhK3eIxR05H59UFsW9C70/hZCQeOhi5Uutl1gAlG4xsJAX9EQjFmmKsN88wmfZvxNPlu0WoxtHxjXKogRfk+wujanMyXnmhHaDrvwIDAQAB",
On 2012/10/31 20:50:11, Dan Beam wrote:
> nit: indent is off for "key"

Done.

https://chromiumcodereview.appspot.com/11336036/diff/17001/chrome/browser/res...
chrome/browser/resources/dev_environment/manifest.json:3: "name": "Chrome
Developer Tool",
This app is suppose to serve a debug cum inspect page for developers. I am not
too sure of the name either. Any other suggestions or we can rename it later as
well.

On 2012/10/31 20:50:11, Dan Beam wrote:
> I'm confused by this name, the directory is called "dev_environment" and I
think
> this will sound like the webkit inspector...

https://chromiumcodereview.appspot.com/11336036/diff/17001/chrome/browser/res...
chrome/browser/resources/dev_environment/manifest.json:13: "icons": { "16":
"images/dev-icon-16.png", "128": "images/dev-icon-128.png" }
On 2012/10/31 20:50:11, Dan Beam wrote:
> nit: no spaces between { and "16" nor .png" and } if you keep oneline,
otherwise
> why is this not the same as the way "app" indents it's object literal?

Done.

[Dan Beam, 2012-10-31 21:17:09]

https://chromiumcodereview.appspot.com/11336036/diff/17001/chrome/browser/res...
File chrome/browser/resources/dev_environment/manifest.json (right):

https://chromiumcodereview.appspot.com/11336036/diff/17001/chrome/browser/res...
chrome/browser/resources/dev_environment/manifest.json:3: "name": "Chrome
Developer Tool",
On 2012/10/31 21:12:13, Gaurav wrote:
> This app is suppose to serve a debug cum inspect page for developers. I am not
> too sure of the name either. Any other suggestions or we can rename it later
as
> well.

If the description is "Debug Chrome apps.", why not [Chrome] App Debugger?  I'd
also expect the directory name to match whatever is chosen here.

> 
> On 2012/10/31 20:50:11, Dan Beam wrote:
> > I'm confused by this name, the directory is called "dev_environment" and I
> think
> > this will sound like the webkit inspector...
>

[Gaurav, 2012-11-01 08:39:56]

https://chromiumcodereview.appspot.com/11336036/diff/17001/chrome/browser/res...
File chrome/browser/resources/dev_environment/manifest.json (right):

https://chromiumcodereview.appspot.com/11336036/diff/17001/chrome/browser/res...
chrome/browser/resources/dev_environment/manifest.json:3: "name": "Chrome
Developer Tool",
On 2012/10/31 21:17:10, Dan Beam wrote:
> On 2012/10/31 21:12:13, Gaurav wrote:
> > This app is suppose to serve a debug cum inspect page for developers. I am
not
> > too sure of the name either. Any other suggestions or we can rename it later
> as
> > well.
> 
> If the description is "Debug Chrome apps.", why not [Chrome] App Debugger? 
I'd
> also expect the directory name to match whatever is chosen here.
> 
> > 
> > On 2012/10/31 20:50:11, Dan Beam wrote:
> > > I'm confused by this name, the directory is called "dev_environment" and I
> > think
> > > this will sound like the webkit inspector...
> > 
> 

Done.

[Dan Beam, 2012-11-01 20:43:19]

lgtm as long as the name matches

https://chromiumcodereview.appspot.com/11336036/diff/25001/chrome/browser/res...
File chrome/browser/resources/apps_debugger/manifest.json (right):

https://chromiumcodereview.appspot.com/11336036/diff/25001/chrome/browser/res...
chrome/browser/resources/apps_debugger/manifest.json:3: "name": "Chrome
Developer Tool",
nit: shouldn't this name match?

[Dan Beam, 2012-11-01 20:43:40]

On 2012/11/01 20:43:19, Dan Beam wrote:
> lgtm as long as the name matches
> 
>
https://chromiumcodereview.appspot.com/11336036/diff/25001/chrome/browser/res...
> File chrome/browser/resources/apps_debugger/manifest.json (right):
> 
>
https://chromiumcodereview.appspot.com/11336036/diff/25001/chrome/browser/res...
> chrome/browser/resources/apps_debugger/manifest.json:3: "name": "Chrome
> Developer Tool",
> nit: shouldn't this name match?

(i.e. "name": "Chrome Apps Debugger" or something along those lines)

[Mihai Parparita -not on Chrome, 2012-11-02 20:10:16]

+1 to using the same name

https://chromiumcodereview.appspot.com/11336036/diff/25001/chrome/browser/ext...
File chrome/browser/extensions/component_loader.cc (right):

https://chromiumcodereview.appspot.com/11336036/diff/25001/chrome/browser/ext...
chrome/browser/extensions/component_loader.cc:329: // Apps Debugger
This should be controlled by a flag.

[commit-bot: I haz the power, 2012-11-05 18:34:05]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/grv@chromium.org/11336036/22018

[commit-bot: I haz the power, 2012-11-05 18:34:08]

Presubmit check for 11336036-22018 failed and returned exit status 1.


Running presubmit commit checks ...

** Presubmit Messages **
--tbr was specified, skipping OWNERS check

** Presubmit Warnings **
License must match:
.*? Copyright (\(c\) )?(2012|2011|2010|2009|2008|2007|2006|2006-2008) The
Chromium Authors\. All rights reserved\.\n.*? Use of this source code is
governed by a BSD-style license that can be\n.*? found in the LICENSE file\.(?:
\*/)?\n
Found a bad license header in these files:
  chrome/browser/resources/apps_debugger/background.js

[commit-bot: I haz the power, 2012-11-06 05:05:57]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/grv@chromium.org/11336036/21004

[commit-bot: I haz the power, 2012-11-06 06:09:38]

Retried try job too often for step(s) browser_tests

[commit-bot: I haz the power, 2012-11-06 17:06:29]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/grv@chromium.org/11336036/26011

[commit-bot: I haz the power, 2012-11-06 18:08:58]

Retried try job too often for step(s) browser_tests

[commit-bot: I haz the power, 2012-11-16 01:04:10]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/grv@chromium.org/11336036/26011

[commit-bot: I haz the power, 2012-11-16 01:58:24]

Retried try job too often for step(s) interactive_ui_tests

[commit-bot: I haz the power, 2012-11-19 21:59:02]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/grv@chromium.org/11336036/43001

[commit-bot: I haz the power, 2012-11-19 22:45:04]

Retried try job too often for step(s) browser_tests

[commit-bot: I haz the power, 2012-11-20 00:08:30]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/grv@chromium.org/11336036/45001

[commit-bot: I haz the power, 2012-11-20 01:28:23]

Retried try job too often for step(s) sync_integration_tests

[commit-bot: I haz the power, 2012-11-28 07:26:28]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/grv@chromium.org/11336036/45001

[commit-bot: I haz the power, 2012-11-28 12:22:54]

Change committed as 169911