Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8587)

Unified Diff: chrome/common/pref_names_util_unittest.cc

Issue 11336008: When a font family pref changes to the empty string, pass it to WebKit. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: review comments Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/common/pref_names_util.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/pref_names_util_unittest.cc
diff --git a/chrome/common/pref_names_util_unittest.cc b/chrome/common/pref_names_util_unittest.cc
new file mode 100644
index 0000000000000000000000000000000000000000..2d1356a77213a438d9036305f693c69d936a315c
--- /dev/null
+++ b/chrome/common/pref_names_util_unittest.cc
@@ -0,0 +1,52 @@
+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/common/pref_names_util.h"
+
+#include "testing/gtest/include/gtest/gtest.h"
+
+namespace {
+
+void ExpectNoParse(const std::string& path) {
+ EXPECT_FALSE(pref_names_util::ParseFontNamePrefPath(path, NULL, NULL));
+}
+
+void ExpectParse(const std::string& path,
+ const std::string& expected_generic_family,
+ const std::string& expected_script)
+{
+ std::string generic_family;
+ std::string script;
+
+ ASSERT_TRUE(pref_names_util::ParseFontNamePrefPath(path, &generic_family,
+ &script));
+ EXPECT_EQ(expected_generic_family, generic_family);
+ EXPECT_EQ(expected_script, script);
+}
+
+} // namespace
+
+TEST(PrefNamesUtilTest, Basic) {
+ ExpectNoParse("");
+ ExpectNoParse(".");
+ ExpectNoParse(".....");
+ ExpectNoParse("webkit.webprefs.fonts.");
+ ExpectNoParse("webkit.webprefs.fonts..");
+ ExpectNoParse("webkit.webprefs.fontsfoobar.standard.Hrkt");
+ ExpectNoParse("foobar.webprefs.fonts.standard.Hrkt");
+ ExpectParse("webkit.webprefs.fonts.standard.Hrkt", "standard", "Hrkt");
+ ExpectParse("webkit.webprefs.fonts.standard.Hrkt.", "standard", "Hrkt.");
+ ExpectParse("webkit.webprefs.fonts.standard.Hrkt.Foobar", "standard",
+ "Hrkt.Foobar");
+
+ // We don't particularly care about the parsed family and script for these
+ // inputs, but just want to make sure it does something reasonable. Returning
+ // false may also be an option.
+ ExpectParse("webkit.webprefs.fonts...", "", ".");
+ ExpectParse("webkit.webprefs.fonts....", "", "..");
+
+ // Check that passing NULL output params is okay.
+ EXPECT_TRUE(pref_names_util::ParseFontNamePrefPath(
+ "webkit.webprefs.fonts.standard.Hrkt", NULL, NULL));
+}
« no previous file with comments | « chrome/common/pref_names_util.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698