ash/metrics/user_metrics_recorder.cc - Issue 1133123003: Added metrics to track the time between task switches done via the shelf.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ash/metrics/user_metrics_recorder.cc

Issue 1133123003: Added metrics to track the time between task switches done via the shelf. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« ash/metrics/task_switch_time_tracker.cc ('K') | « ash/metrics/user_metrics_recorder.h ('k') | ash/test/task_switch_time_tracker_test_api.h » ('j') | tools/metrics/histograms/histograms.xml » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ash/metrics/user_metrics_recorder.cc

diff --git a/ash/metrics/user_metrics_recorder.cc b/ash/metrics/user_metrics_recorder.cc

index dee488bae57d74d65d47624096442116ed06b2ed..3cdbbb669e47f066177e8c1a8de89b7837f69d47 100644

--- a/ash/metrics/user_metrics_recorder.cc

+++ b/ash/metrics/user_metrics_recorder.cc

@@ -231,12 +231,16 @@ void UserMetricsRecorder::RecordUserMetricsAction(UserMetricsAction action) {

break;

case ash::UMA_LAUNCHER_LAUNCH_TASK:

base::RecordAction(base::UserMetricsAction("Launcher_LaunchTask"));

+ task_switch_metrics_recorder_.OnTaskSwitch(

+ TaskSwitchMetricsRecorder::kShelf);

break;

case ash::UMA_LAUNCHER_MINIMIZE_TASK:

base::RecordAction(base::UserMetricsAction("Launcher_MinimizeTask"));

break;

case ash::UMA_LAUNCHER_SWITCH_TASK:

base::RecordAction(base::UserMetricsAction("Launcher_SwitchTask"));

+ task_switch_metrics_recorder_.OnTaskSwitch(

+ TaskSwitchMetricsRecorder::kShelf);

break;

case UMA_MAXIMIZE_MODE_DISABLED:

base::RecordAction(base::UserMetricsAction("Touchview_Disabled"));